pardoman / twitchtvchat Goto Github PK

This happens because chaning the current channel may happen through ajax, and a new video player is created. However, the extension is still loaded and keeping a reference to a no-longer-in-stage canvas2d.

Solution: detect when the cached player gets removed from dom and clear extension's internal variables.

Might be cool to have.
Maybe have an option to toggle it on/off

Finally, using some sort of color to distinguish the name from the message could be nice. Will have to try and see if it actually works.

This is because it relies on some simple Math.random() logic, which will never be great.

What we need is some sort of priority queue, that takes into account the length of the text, so that short text can co-live in the same line while long text can occupy a line without any other new text jumping on it.

To better repro this issue, inject overlay to an active stream chat.
For example, a tournament event

Repro steps:

1. Inject overlay
2. Change browser tab to something else (google.com for example)
3. Wait about 10 seconds.
4. tab back to twitch stream

RESULT: Notice that new text will show up and pilled up to the left.
EXPECTED: Chats should not be piled to the right. Some texts should be midway through their path, other leaving the screen on the left.

Canvas is actually not great when it comes to performance.
There's way too much re-rendering of the whole area, specially in fullscreen mode.

A better approach is to leverage browser's native text rendering.

Ideally this extension should work on fullscreen mode. The problem is that the video player is flash, and drawing html on top of flash is not doable afaik.

Maybe when the html5 video player is available we can look into it.

Steps:

1. Enter a channel
2. Wait until it finishes and rehosts some other one (lol)

RESULT: The extension fails to re-inject itself to the rehosted stream
EXPECTED: The extension re-injects to the rehosted steam smoothly.

WORKAROUND: Refresh the page.

Would be nice to have icons within the bullet text, like those from JustinBob4 in the image above.