pantheon-systems / terminus-quicksilver-plugin Goto Github PK

When working with a site that is using webdocroot, this plugin installs the scripts in the project root's "private" directory, not the web/private directory.

Seems like the quicksilver:install command should check the web_docroot value in an existing pantheon.yml and act accordingly.

-mike

As an agency, I might want to structure my-agency/.quicksilver repository like so:

-/scripts
--/integration_1
--/integration_1/readme.md
--/integration_1/integration_1.php
-quicksilver.yml

This would allow for developers across an agency to: clone the agency's scripts repository to $HOME, and then run terminus quicksilver profile d8 from a new D8 site's repository, push to Pantheon, run terminus secrets, and be up and running the fastest.

$ composer global install pantheon-systems/quicksilver-cli
Changed current directory to /Users/jordanryan/.composer
Invalid argument pantheon-systems/quicksilver-cli. Use "composer require pantheon-systems/quicksilver-cli" instead to add packages to your composer.json.

Seeing these when I install new plugins:

PHP Notice:  Undefined variable: siteType in /Users/joshk/terminus/plugins/terminus-quicksilver-plugin/Commands/QuicksilverCommand.php on line 201

Notice: Undefined variable: siteType in /Users/joshk/terminus/plugins/terminus-quicksilver-plugin/Commands/QuicksilverCommand.php on line 201
PHP Notice:  Undefined variable: majorVersion in /Users/joshk/terminus/plugins/terminus-quicksilver-plugin/Commands/QuicksilverCommand.php on line 201

Notice: Undefined variable: majorVersion in /Users/joshk/terminus/plugins/terminus-quicksilver-plugin/Commands/QuicksilverCommand.php on line 201

If I specify my own quicksilver repository on github, I want the option to install the whole thing instead of one directory at a time. This subcommand would use a complete pantheon.yml in the repo root instead of the snippets embedded in the readme in each directory, and would get each script.

My first guess when setting this up is that it would work directly with my sites on Pantheon. I didn't expect that it would require a local clone, and was confused when it just put a pantheon.yml file in my home directory.

If we're going to make it require a local working copy, we should probably put some safeguards in place and check that the current working directory is the root of a valid Git repo before doing anything. We can even provide informative instructions if not.

Alternatively, we could also operate over SFTP mode and do the commits remotely. That's probably more work.

Following a successful installation with composer, the quicksilver-cli command is not found.

"Ensure that ~/.composer/vendor/bin is in your global $PATH."

Taras-MacBook-Pro:hello-my-drupal tararowell$ echo $PATH /usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:~/.composer/vendor/bin:/opt/X11/bin:/Applications/DevDesktop/drush

/Users/tararowell/.quicksilver/quicksilver.yml contents

# Quicksilver configuration file
#
# Copy to $HOME/.quicksilver/quicksilver.yml
#
repositories:
  slack_notification: https://github.com/pantheon-systems/quicksilver-examples