pantheon-systems / drops-6 Goto Github PK

Found deprecated function in includes/unicode.inc and I think I have a patch. Please try it and add it to core if it works.

Contents of the patch are below:

diff --git a/includes/unicode.inc b/includes/unicode.inc
index b1ce757..a302ef7 100644
--- a/includes/unicode.inc
+++ b/includes/unicode.inc
@@ -346,7 +346,7 @@ function decode_entities($text, $exclude = array()) {
// double-escaped entities twice. The PREG_REPLACE_EVAL modifier 'e' is
// being used to allow for a callback (see
// http://php.net/manual/en/reference.pcre.pattern.modifiers).

• return preg_replace('/&(#x?)?([A-Za-z0-9]+);/e', '_decode_entities("$1", "$2", "$0", $html_entities, $exclude)', $text);
• return preg_replace_callback('/&(#x?)?([A-Za-z0-9]+);/', create_function('$match', 'return _decode_entities("$1", "$2", "$0", $html_entities, $exclude);'), $text);
  }

/**

Thank you,
-Landi

The function openid_update_6001() is repeated twice in modules/openid/openid.install.

See: https://github.com/pantheon-systems/drops-6/blob/master/modules/openid/openid.install#L211

Its repeated at line 148 and 211.

This causes a fatal error and should just be removed.

[edited] ignore please wrong repo

We have tests running on pull request for some of our major repositories like https://github.com/pantheon-systems/drops-8 and https://github.com/pantheon-systems/WordPress. Adding similar tests here to verify installation and basic administrative tasks will give us more confidence in merging pull requests.

Hey Pantheon,

I noticed a bug on my D6 website and I found out that it's actually a bug in Pressflow. I'd hate to patch core on my own and have to re-patch it at every core update, so I'd love if you could include this patch into your updates.

The bug and the patch are documented on this thread:

Drush error on verbose flag “: in (line of ).” https://drupal.org/node/979672
See comment #37, #38, and #39 for the fix

The patch fixes the file /code/sites/includes/common.inc
line 4040
from

drupal_set_message(t(

to

drupal_set_message(strtr(

Thanks!