Rework the README and branding about memo_wise HOT 4 CLOSED

Does that make sense?

Ah yes! So just to confirm my understanding. The order of the private and memo_wise call will impact what we do internally. But in both cases we'll ultimately have a private memoized method.

In this case, you're totally right, let's remove it!

from memo_wise.

@jemmaissroff I'm not sure I totally follow the last item in the checklist:

Document that changing method visibility must occur before memoizing methods in order to preserve visibility. (See #59 for more detail.)

If I do:

memo_wise :foo
private :foo

or

private :foo
memo_wise :foo

isn't the result of both of these the same, i.e. foo will be both memoized and private?

from memo_wise.

@JacobEvelyn re:

isn't the result of both of these the same, i.e. foo will be both memoized and private?
Yes, you're actually totally right. I just ran the tests locally switching the order. But can you explain to me how that's working?

My assumption was that if we made the method private after memoizing it, it wouldn't be private when we check private_method_defined? within #memo_wise. Can you explain to me why that doesn't matter?

from memo_wise.

Can you explain to me why that doesn't matter?

Sure! In this case:

memo_wise :foo
private :foo

We're first creating a new public method foo, which wraps the behavior of the old (now-private) method foo. (You're right that neither is private at the time of the private_method_defined? check.) But then on the next line when we call private :foo we're making our new memoized method private.

Does that make sense?

from memo_wise.