Dependent policy loses track of dependee failure reason about action_policy HOT 4 CLOSED

class DependeePolicy
  def do_it?
    check?(:a?) && check?(:b?)
  end

  def do_that?
      b? || c?
  end

  def a?
    true
  end

  def b?
    false
  end

  def c?
    false
  end
end

class DependerPolicy
  def do_it?
    check?(:do_it?, record.dependee) && check?(:c?)
  end

  def do_that?
    check?(:do_that?, record.dependee) || check?(:d?)
  end

  def c?
    true
  end

  def d?
    false
  end
end

# first case: self-check
begin
  authorize! dependee, to: :do_it?
rescue ActionPolicy::Unauthorized => e
  puts e.result.reasons.details # { :dependee => [:b?] }
end

# 1: self-check
begin
  authorize! dependee, to: :do_it?
rescue ActionPolicy::Unauthorized => e
  puts e.result.reasons.details # { :dependee => [:b?] }
end

# 2: no checks
begin
  authorize! dependee, to: :do_that?
rescue ActionPolicy::Unauthorized => e
  puts e.result.reasons.details # {}
end

# 3: sub-policy check with sub-checks
begin
  authorize! depender, to: :do_it?
rescue ActionPolicy::Unauthorized => e
  puts e.result.reasons.details # { :dependee => [:b?] }
end

# 3: sub-policy check without sub-checks
begin
  authorize! depender, to: :do_that?
rescue ActionPolicy::Unauthorized => e
  # NOTE: we use dependee rule as reason, 'cause no reasons were populated in sub-call
  puts e.result.reasons.details # { :dependee => [:do_that?], :depender => [:d?] }
end

begin
  authorize! dependee, to: :do_it?
rescue ActionPolicy::Unauthorized => e
  msg = e.result.message

  if e.result.reasons.any?
    msg << ": #{e.result.reasons.full_messages.map(&:downcase).join(', ')}"
  end

  puts msg
end