Git Product home page Git Product logo

Comments (1)

palkan avatar palkan commented on May 28, 2024 1

Correct. In tests, you must be explicit about the authorization target object or the policy class that must be used. The goal of the test is to verify the correct policy has been used.

We can hardly infer the expected class from a test class (well, maybe, we can assume that described_class is a controller class, so we can get the name and turn it into a policy name, but that would made tests too vague). And I can see how that can lead to false positives: you change the controller name (say, PostsController > DrafsController); now a DraftPolicy is used implicitly and in tests we also implicitly check for it; but you might want to continue using PostPolicy—the test wouldn't catch this.

If I do this, how can I test it using RSpec?

expect { get posts_path }.to be_authorized_to(:index?, Post)

# or
expect { get posts_path }.to be_authorized_to(:index?, :post)

Though I think the following would be even better:

expect { get posts_path }.to be_authorized_to(:index?).with(PostPolicy)

from action_policy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.