Git Product home page Git Product logo

Comments (7)

brendon avatar brendon commented on May 14, 2024 1

I've hit this too. It seems the idea is that if a hard rule has been defined in a superclass, an alias_rule in a subclass has no effect.

from action_policy.

palkan avatar palkan commented on May 14, 2024

Aliases should be overridable (see this test: https://github.com/palkan/action_policy/blob/master/test/action_policy/policy/aliases_test.rb#L52).

Could you, please, provide the output for: GroupPolicy.new(user: User.new).resolve_rule(:new?) ?

from action_policy.

jacobwalkr avatar jacobwalkr commented on May 14, 2024
irb(main):012:0> GroupPolicy.new(user: User.new).resolve_rule(:new?)
=> :index?
irb(main):013:0> GroupPolicy.new(user: User.new).resolve_rule(:create?)
=> :create?

This is with defaults included in the ApplicationPolicy and this GroupPolicy:

class GroupPolicy < ApplicationPolicy
  def index?
    true
  end
  alias_rule :new?, :create?, :edit?, :update?, to: :index?
end

from action_policy.

jacobwalkr avatar jacobwalkr commented on May 14, 2024

I tried the other routes for fun:

irb(main):014:0> GroupPolicy.new(user: User.new).resolve_rule(:index?)
=> :index?
irb(main):015:0> GroupPolicy.new(user: User.new).resolve_rule(:edit?)
=> :index?
irb(main):016:0> GroupPolicy.new(user: User.new).resolve_rule(:update?)
=> :index?
irb(main):017:0> GroupPolicy.new(user: User.new).resolve_rule(:destroy?)
=> :default_rule
irb(main):018:0> GroupPolicy.new(user: User.new).resolve_rule(:show?)
=> :default_rule

default_rule is defined in our ApplicationPolicy.

from action_policy.

jacobwalkr avatar jacobwalkr commented on May 14, 2024

If I remove defaults from ApplicationPolicy:

irb(main):025:0> GroupPolicy.new(user: User.new).resolve_rule(:create?)
=> :index?

from action_policy.

jacobwalkr avatar jacobwalkr commented on May 14, 2024

Thanks for your work, guys. This is super helpful and I wouldn't have known where to start 😊

from action_policy.

brendon avatar brendon commented on May 14, 2024

You're most welcome :) Now I know a lot about action_policy! :D

from action_policy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.