Does not reload code changes when using namespaces about action_policy HOT 7 CLOSED

Why namespaced class has the cache but class without namespaced hasn't.

Namespaced lookup is more expensive. I've added a benchmark which shows that it could be 4x slower without cache:

Comparison:
               cache:   178745.5 i/s
             cache B:   169435.4 i/s - same-ish: difference falls within error
          no cache A:    95312.7 i/s - same-ish: difference falls within error
          no cache B:    43121.0 i/s - 4.15x  slower

Also as I see from the source, found namespaced policy also cache in the object and in the thread. Will not it be easy and simple just remove NamespaceCache mechanism 🙂?

NamespaceCache caches a policy class for a given namespace and a policy name, we use it every time we want to initialize a policy within the matching context.
Per-thread and instance caches store policy instances, they only re-used within a single request. We still have to resolve a policy class.

from action_policy.

Could this be related to #14?

from action_policy.

@jacobwalkr may be. There are additions if I call authorize! and specify policy directly via the with option, changes in the policy are applied without restarting the server

from action_policy.

Got the same reload issue.
After some investigation found the reason - NamespaceCache class, which hold Hash with first-time loaded policy class and clear it only on init.

Seams that in development this cache must be disabled or must be clearing on each request.

from action_policy.

@ycherniavskyi

Thanks for the investigation!

Seams that in development this cache must be disabled or must be clearing on each request.

We should add a configuration to disable this cache, and disable it by default in development env.

We can also embrace app.reload.before_class_unload callback for Rails 5 and clear the cache.

If anyone is willing to propose a PR – you're welcome! If not – I'll take care of it a little bit later.

from action_policy.

@palkan could you please explain a bit the exact purpose of NamespaceCache class. Why namespaced class has the cache but class without namespaced hasn't.

Also as I see from the source, found namespaced policy also cache in the object and in the thread. Will not it be easy and simple just remove NamespaceCache mechanism 🙂?

from action_policy.

Fixed by 1d4a2e7 and released in 0.2.3.

from action_policy.