Git Product home page Git Product logo

pgwbrowser's People

Contributors

bgurney avatar jonathan-piat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

pgwbrowser's Issues

Not working in IE8?

Hi, it shows my user-agent string as:
Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)

But the PgwBrowser has found:
Loading... It just shows Loading and doesn't actually load the browser details?

Thanks,
-Roman

OS Windows XP 64bit not fully detected

On your test page my XP 64 is only detected as "Windows", not as "Windows XP". The essential string in the UserAgent is Windows NT 5.2 (note the 5.2). Would you consider to add this OS to your plugin?
Here the UserAgent strings from my 4 browsers:

Opera   - Opera/9.80 (Windows NT 5.2; WOW64) Presto/2.12.388 Version/12.17
Chrome  - Mozilla/5.0 (Windows NT 5.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.99 Safari/537.36
FireFox - Mozilla/5.0 (Windows NT 5.2; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
IE8     - Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; WOW64; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET CLR 1.1.4322; .NET4.0C; .NET4.0E)

Thanks

Browser is mobile

Hi Jonathan,

I think in the futur, it will be nice to add an attribute "desktop" or "mobile" in "os" node.

If "os" group is "Windows Phone" or "Android" or "iOS":

desktop:false;
// or mobile:true;

In the other cases:

desktop:true;
// or mobile:false;

Regards,

Incorrect RegExp pattern strings

For example, the identifier pattern string for Mavericks should be 'Mac OS X (10([_|\.])9([0-9_\.]*))'

The . character is preceded by \ since . is a RegExp special character that matches any non-whitespace character.

OS X version 10.10.0 shows up as "Mac OS X Puma"

On the test page using OS X Yosemite, the OS version number is correctly detected as 10.10.0. When parsed, this shows up as Mac OS X Puma.

  "os": {
      "name": "Mac OS X Puma",
      "group": "Mac OS",
      "fullVersion": "10.10.0",
      "majorVersion": 10,
      "minorVersion": 10
   }

Is this just as simple as adding the following?

{ name: 'Mac OS X Yosemite', group: 'Mac OS', identifier: 'Mac OS X (10([_|.])10([0-9_.]*))', versionSeparator: '[_|.]' },

Add bower.json file

Changes

  • Add bower.json file to add this module to bower.io

Instructions (After merged)

  • After merging this file, package should be registered in bower by using:
bower register pgwbrowser git://github.com/Pagawa/PgwBrowser.git

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.