Enhancement: Sub Catagorize Rolls about dragonbane HOT 7 CLOSED

I would not recommend parsing localized text. Adding the skillId would let you find the skill and check skill type on the item in a language independent way.

from dragonbane.

Resolved in 06573f0

from dragonbane.

I have considered adding info in msg.content to identify skill rolls, e.g. add classes "skill-roll" / "attribute-roll" and "data-skill-id" / "data-attribute", etc. Would that do the job?

from dragonbane.

Looks like it could do the job. I guess big thing is seeing the different types of skill rolls. Weapon skills vs secondary skills, vs primary skills. Dont quite know if the msg.content would get that granular or not.

Currently there’s no way to tell the difference.

from dragonbane.

Doing a Bit more testing I can parse by checking the flavor string for Attack, Topple, Disarm, and Parry to partially solve the issue.
Rolling a weapon skill from the Skills Tab will always just say "... Skill ..." with no way to tell what type of skill was rolled though.

from dragonbane.

True, Forgot entirely about text being localized. That would def could fix the skill issue.

Although it would have issues telling if it was a damage roll or Attack roll at that point though as both of those wouldn't have any skill associated.

from dragonbane.

I have considered adding info in msg.content to identify skill rolls, e.g. add classes "skill-roll" / "attribute-roll" and "data-skill-id" / "data-attribute", etc. Would that do the job?

Actually, then this could def work. I could just pull the skill ID from here and see the type, Otherwise see if its attack vs Attribute. Temp solution of text parsing and will update if this gets implemented.

from dragonbane.