padok-team / guacamole Goto Github PK

While it is not a minor issues, it can lead to longer plan and general complexity in the codebase.

Note that for a module which is distributed (not imbeded in the codebase), the rule might not be relevant since you don't know which outputs will actually be used or not.

The. .goreleaser.yaml config creates new releases with a download strategy that requires to be part of padok-team to download Guacamole through Padok's Homebrew tap. With Guacamole being now public, this restriction should be lifted.

Here are the relevant lines:
https://github.com/padok-team/guacamole/blob/1862a03dc11c58927cecead59277dce76b2b10e2/.goreleaser.yaml#L48C1-L57C39

@cterence @Laudenlaruto damn that is cool ! Love the heritage and learning from YATAS in the code ! Looks amazing guys !

You can close the issue ;)

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update docker.io/library/golang:1.22.0 docker digest to 7b297d9
• fix(deps): update module github.com/gruntwork-io/terragrunt to v0.55.8

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

It would be nice to be able to skip some checks which are found to be false positives.
Several ways of implementing it:

• A comment above a terraform block with the check identifier makes Guacamole skip the check on the specific block
• A comment on top of a terraform file with the check identifier makes Guacamole skip the check on the entire file
• Checkov-style baseline file

The TF_MOD_001 (Remote module call should be pinned to a specific version) fails for my codebase when it should pass.

My module is defined as such:

module "keyvault" {
  source = "[email protected]:/padok-team/terraform-azurerm-keyvault?ref=v0.5.1"
  name   = local.name
  ...
}

The module version is pinned to 0.5.1, therefore the check should pass.

The check TF_NAM_004 assumes that the name of a variable of type number should not be plural, but there are a lot of reasons why this doesn't make sens.

Example

variable "number_of_hosts" {
  description = "Number of hosts you want to create"
  type        = number
}