Git Product home page Git Product logo

Comments (7)

erluko avatar erluko commented on June 21, 2024

In addition to fixing the main field in package.json, I had to edit mmap-io.js since it refers to a nonexistent es-release directory. Changing this to Release allowed the import to succeed on my system.

from mmap-io.

LiamKarlMitchell avatar LiamKarlMitchell commented on June 21, 2024

In package.json replace all "es-release" with "Release".
In nmap-io.js replace "es-release" with "Release".
In tsconfig.json replace "es-release" with "Release".
In package.json add "main": "mmap-io.js"

from mmap-io.

ozra avatar ozra commented on June 21, 2024

Sorry I didn't see the github notifications earlier, fixed and updated. Holler and tag me if you have any problems!

from mmap-io.

gcampax avatar gcampax commented on June 21, 2024

Sorry, this is not fixed yet. The build artifact live in build/Release because you use node-gyp (as you should), but mmap-io.js imports build/es-release/mmap-io.
See an example of build failure: https://travis-ci.com/stanford-oval/genie-toolkit/builds/118448865 (from greenkeeper trying the new build on my project)

from mmap-io.

gcampax avatar gcampax commented on June 21, 2024

(tagging @ozra as requested)

from mmap-io.

ozra avatar ozra commented on June 21, 2024

Alright, I'll go over it again, I'll dig up some of my old Quant-projects that use it heavily, and see how it behaves and get it right.

from mmap-io.

ozra avatar ozra commented on June 21, 2024

So...

  1. the es-release files where black-listed and therefor not packaged into the npm
  2. when they got with, they where wiped out on installment when the binary was rebuilt
  • turns out just getting rid of the Makefile caused more crap than I ever had imagined, this actually took longer to get straight than rewriting the horror-show V8-code [ed: because they break compatibility every few months ] xD

Anyway, the js-files are now built into "dist" instead, and the binary into "build" as before, to keep them separated and thereby allow them to be built pre-publish and avoid unnecessary dependencies for the end-user, as intended.

Well. Should shit still roar up — just tag and shout out. Your project seems really cool by the way! I've bookmarked it along with a trail of others I found from it. For "when there is time" xD

Cheers!

from mmap-io.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.