nan dependency version about mmap-io HOT 7 CLOSED

I've updated 'nan' inside pull request to 1.9.0, but iojs build still falling, probably need to rewrite module with compatible for latest nan (2.0.5), or just drop support for iojs. Current version of mmap-io doesn't work even on nodejs, so I think its maybe reasonable merge this pull request and release new version.

from mmap-io.

Hi @penpen - sorry I've completely missed this issue! I'm a bit in a tight spot with time atm - so I will merge your PR without review. Please follow up if you come across issues. :)

from mmap-io.

Hi, thank you! Can you release new version of mmap-io with this commit?

from mmap-io.

Hey. I just re-read and see that it doesn't work at all for iojs!? Have you looked into what changes are affecting? I'll merge PR if you can manage?

from mmap-io.

Hi,
They changed API, so current version in repo won’t work with iojs at all, but with my PR it will work with nodejs
at least. I don’t have much experience with bindings, so I cannot fix this by myself.

On 01 Oct 2015, at 17:29, Oscar Campbell [email protected] wrote:

Hey. I just re-read and see that it doesn't work at all for iojs!? Have you looked into what changes are affecting? I'll merge PR if you can manage?

—
Reply to this email directly or view it on GitHub #1 (comment).

from mmap-io.

What the hell - I'll drop what I'm with and sneak off for some NAN hacking. I'll see if I can fix it.

from mmap-io.

Ok, 10 Snus, 20 cigarilles and 5 cups of coffee later. Seems to work with 2.0.9 now. Published. Try it out.

from mmap-io.