oychao / promise-jsonfile Goto Github PK

Here the console.log should be moved inside the if clause and maybe replaced with a console.error. It logs an unwanted "null".
I was searching through my own code to discover the leaking console.log and found it in your package.
It's nothing dramatical, but it helps guys like me, that forget were they put logs in their own code :)
Thanks a lot for your time.

Hello and thank you.
I think I found a bug
here thats very easy to fix.
After rejecting execution should stop. Otherwise it will try to stripBOM from an undefined buffer and therefore crash.
I could easily be fix it by wrapping the rest of the function in an else clause or inserting a return after the reject clause.