Git Product home page Git Product logo

Comments (11)

echoix avatar echoix commented on June 30, 2024 1

That's why we are a team!

from megalinter.

nvuillam avatar nvuillam commented on June 30, 2024

What linter do you need that is not present in python flavor ? :)

from megalinter.

tcsenpai avatar tcsenpai commented on June 30, 2024

from megalinter.

nvuillam avatar nvuillam commented on June 30, 2024

Please can you try the python flavor and check the logs ? :)

from megalinter.

adhil0 avatar adhil0 commented on June 30, 2024

@nvuillam It looks like the python flavor is missing the JS/TS linters. Maybe it would be a good idea to create a pythonweb flavor, similar to dotnetweb? It Could cover apps that use Flask, Django, FastAPI, etc.

If you think it's a good idea, could you assign me to this issue? Would like to try contributing

from megalinter.

nvuillam avatar nvuillam commented on June 30, 2024

@adhil0 I'm ok for a pythonweb flavor :)

You can submit a PR, and take inspiration from #2778 :)

Note: flavor_factory.py + descriptor yml files are enough to add a new flavor, the rest of the updates are generated during the build

from megalinter.

echoix avatar echoix commented on June 30, 2024

I'm curious about the final size it would have compared to another one, like cupcake. I'm not sure only for that framework it would be worth the amount of CI that would be needed each time for that specific framework (Python and web, except for some (older) Django, isn't that common) is something that would benefit enough.
I'm not against, but I'd like to be convinced more with some numbers on what is saved, what is cost to save, etc. It's good to explore though!

from megalinter.

adhil0 avatar adhil0 commented on June 30, 2024

These are some good questions, I can help investigate. Of course, anyone else who's interested is more than welcome to join in as well!

from megalinter.

echoix avatar echoix commented on June 30, 2024

I have to be the watchdog since we're near the limit of having to reorganize the structure because we are occasionally hitting API limits. The dotnet web flavor was a case where a common workload with ASP.NET didn't fit anything else. And since the size of the dotnet SDK is huge for what is really used (and a bit picky to integrate), it wasn't available in the cupcake flavor (the more balanced flavor), the full image is a bit big when you know the tools you want to use, and the dotnet-only flavor was missing a bit of tools.

from megalinter.

nvuillam avatar nvuillam commented on June 30, 2024

@adhil0 if you make the PR we'll be able to compare size with cupcake flavor :)

@echoix thanks for being more cautious than i am sometimes:)

from megalinter.

github-actions avatar github-actions commented on June 30, 2024

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale πŸ€– label or comment on the issue.

from megalinter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.