Investigate adding address sanitizer about template-project-cpp HOT 8 CLOSED

have a look at how I did the openmp compile and link flags using target_compile_options and target_link_libraries:

# OpenMP as an optional component for tests
option(Template_USE_OPENMP "Use OpenMP for shared memory parallism" OFF)
if (Template_USE_OPENMP)
    find_package(OpenMP REQUIRED)
    target_compile_options(mytest PRIVATE "${OpenMP_CXX_FLAGS}")
    target_link_libraries(mytest PRIVATE "${OpenMP_EXE_LINKER_FLAGS}")
endif()

You will also need to filter out only the clang compiler as well
If you need these flags for both the library and test executables, best way is to add them to mylib as PUBLIC, then they will automatically be transferred to mytest

from template-project-cpp.

I have an implementation ready to go, just want your opinion @martinjrobins:

If someone runs cmake -DTemplate_MEMCHECK=ON and they are using gcc rather than clang, would you prefer a CMake WARNING or a CMake FATAL_ERROR?

I think if the user specifically requests functionality it's OK to make it a FATAL_ERROR?

from template-project-cpp.

I agree, make it a FATAL_ERROR. If I request a feature and it can't be satisfied, that is an error.

from template-project-cpp.

Happy with that changeset @martinjrobins ?

from template-project-cpp.

looks good. We might also want to change the way that the coverage option is handled so that it is consistent with the memcheck

from template-project-cpp.

Do we just want coverage on GCC, or Clang too?

from template-project-cpp.

from template-project-cpp.

OK - I'll close this issue and open a new one for sorting out coverage.

from template-project-cpp.