Git Product home page Git Product logo

Comments (7)

martinjrobins avatar martinjrobins commented on September 24, 2024

Thanks for this. I'm thinking about dropping eigen and vtk to stop the cmakelists file getting too verbose, leaving just boost and openmp.

I've tried using modern cmake, except for the dependencies. You are supposed to import these as targets now, but many finders don't support this currently, so I'm thinking of sticking to manual including/linking.

I've put in a couple of clang-format and clang-tidy configs from old projects, but these need editing.

Everything is still in draft form and no-where near working, so I've also added a warning in the readme, in case someone stumbles on this repo and tries to use it.

from template-project-cpp.

martinjrobins avatar martinjrobins commented on September 24, 2024

mostly there now. still need to get appveyor working, and put in an openmp test (e.g. sum all the primes from 0-1000). And not sure what to do with clang-tidy

from template-project-cpp.

fcooper8472 avatar fcooper8472 commented on September 24, 2024

Clang tidy now integrated. Can we add this in to the continuous integration somehow @martinjrobins?
Would be nice to build with clang tidy enabled, possibly even fail if warnings are emitted?

from template-project-cpp.

martinjrobins avatar martinjrobins commented on September 24, 2024

I'd be happy to leave them as warnings for the moment, although we should enable clang tidy on travis. I kinda like the separation between warnings and errors (rather than treating warnings as errors).

from template-project-cpp.

fcooper8472 avatar fcooper8472 commented on September 24, 2024

Agreed - I just wondered if there's an easy way to automate the running of it.

Something like an additional yellow badge on the repo if there are any warnings from a clang-tidy build?
No idea if that's possible.

from template-project-cpp.

martinjrobins avatar martinjrobins commented on September 24, 2024

I've removed the openmp stuff, I don't think it adds much, and is a pain to get working due to flaky cmake find routine, happy with this @fcooper8472 ? If so then I think we can close this one .

from template-project-cpp.

fcooper8472 avatar fcooper8472 commented on September 24, 2024

Yep, happy to ditch openmp.

Let's close this one now, but perhaps think about adding in some other common libs in the future (I think a lot of mathsy people ought to be using something like Eigen).

from template-project-cpp.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.