owd-larrd / gmaps-utility-library-dev Goto Github PK

What steps will reproduce the problem?
1. I've added LabeledMarker to MarkerManager
2. updating the location of marker with setLatLng 
3. the marker moves as wanted, but the label doesn't move

What is the expected output? What do you see instead?
Marker and it's label change to new point. Marker change position, but
label doesn't

What version of the product are you using? On what operating system?
release, Windows Vista

Please provide any additional information below.
If the label doesn't move automatically, it would be nice to have ways to
remove label and add label afterwards. Also I'd like to have possibility to
change the labeltext later. 

the DragZoomControl.prototype.getRectangle_ function currently enforces a
fixed aspect ratio, it would be nice to make this optional

along the lines of 

if (forceAspectRatio)
    return {
      startX: startX,
      startY: startY,
      endX: startX + delta,
      endY: startY + parseInt(delta * ratio),
      width: delta,
      height: parseInt(delta * ratio),
      left:left,
      top:top
    }
  else
     return {
        startX: startX,
        startY: startY,
        endX: pos.left,
        endY: pos.top,
        width: dX,
        height: dY,
        left:left,
        top:top
      }  

Left to zoom in, right to zoom out. Makes sense :)

Currently dragging with the right mouse is the same as with the left.

The attached patch against r522 adds:
 * an option, 'opts_other.rightMouseZoomOutEnabled' which enables the
behaviour. Default is false (existing behavior)
 * if enabled, dragging with the right button tries to find a zoom level to
fit the current visible extent in the size of the dragged box. This is
'normal' behavior for a number of other mapping systems.

MM and MT didn't start off with packed versions. I've retroactively added a
packed JS to their release folders, but we should add both packed versions
and packed examples here.

Mappers would like an example using LabeledMarker with zIndexProcess for
marker-depth swapping (like Esa's ZMarker
)

From Gary- 

I recommend adding an Events section to the DragZoomControl documentation
to clarify that the control will fire events when a zoom area is selected
and also when the frame around the selected area is removed.

As things stand right now, it's not obvious to an application programmer
that using DragZoomControl will cause events to be passed to an addoverlay
or removeoverlay handler. If the handler isn't expecting such events, there
could be problems -- as we've seen! 

-----------

NEW SECTION FOR DRAGZOOM DOCUMENTATION

Events

Events -- Arguments -- Description

addoverlay -- overlay -- This event is fired when the mouse button is
released after a zoom rectangle has been specified. The GPolyline
representing the frame around the selected area is passed as the overlay
argument.

removeoverlay -- overlay -- This event is fired when the GPolyline
representing the frame around the selected area (passed as the overlay
argument) is removed. This occurs overlayRemoveTime milliseconds after the
area was specified.

Currently we do not have an option to show a small tooltip about marker
show with tracker, user will happy to know what there before they go there,
a small tooltip will be help (eg. for very short description)

What steps will reproduce the problem?
  Use marker.copy() on a labeled marker. E.g. call .showMapBlowup() on a
map that contains a labeled marker.

What do you see instead?
  The code crashes with "this.opt_opts_ is not defined"

Please provide any additional information below.
The fix would be to use the correct variable name in .copy(). I.e. change this:

LabeledMarker.prototype.copy = function() {
  return new LabeledMarker(this.latlng_, this.opt_opts_);
}

to this:

LabeledMarker.prototype.copy = function() {
  return new LabeledMarker(this.latlng_, this.opts_);
}

What steps will reproduce the problem?
1. create a marker that opens an ExtInfoWindow on click, but closes the
ExtInfoWindow on double click.
2. double click on the marker.
3. a javascript error occurs because ExtInfoWindow.prototype.ajaxRequest_
does not test for ExtInfoWindow existence.

What is the expected output? What do you see instead?

The expected output is that no javascript error occurs. However, a
"getExtInfoWindow() has no properties" error occurs at the line "var
infoWindow =
document.getElementById(thisMap.getExtInfoWindow().infoWindowId_ +
'_contents');", because the ExtInfoWindow is already closed by the double
click action.

What version of the product are you using? On what operating system?

Release (1.0) Version of ExtInfoWindow.

Please provide any additional information below.

Put "if (thisMap.getExtInfoWindow() != null) {" before "var infoWindow =
document.getElementById(thisMap.getExtInfoWindow().infoWindowId_ +
'_contents');" and "}" after the resize action, and this issue is resolved.

Initially reported in Issue 19.

Also related to LabeledMarker 1.1, I notice that the show() and hide() routines 
alter the visibility 
style property.  I've always felt that it is best to alter the display property 
instead for showing 
(display: anything) and hiding (display: none) -- this should improve 
performance if you have 
lots of markers because the browser, when rendering a page, will ignore a 
display:none label div 
completely instead of having to calculate the size of the space to allocate for 
each 
visibility:hidden div.

However, I'm not sure what the show and hide code for a standard marker looks 
like -- I 
suppose if this code alters the visibility property, the code for 
hiding/showing the labels should 
follow suit. Or maybe the marker code should be changed??

The libraries could use a little cleaning.

Typo: There's also a typo in Changed under Marker Manager it says fist
instead of first.

"The fist one is the rectangle definining the bounds of the visible grid"

It would be useful to be able to get the data needed to center on and zoom
to view all the markers in a manager.

Only issues specific to the release project (or perhaps none at all) should be 
on the release project.

We should probably move other issues to the development project and add an 
issue to the release 
project pointing users to the development project.  Alternately, we could move 
the issues over and 
just disable the release project issues tab.

To avoid function name clashes in the future, there should be no functions
in our libraries that don't belong to a class (unless the library is
specifically a library of utility functions)

Found this one in LabeledMarker:
function newEventPassthru 

Reported by ebessette, Jun 02 (5 days ago) originally:
http://code.google.com/p/gmaps-utility-library/issues/detail?id=7

I'd really like to see a Google Web Kit (GWT) wrapper for this library.

Requested in group:
http://groups.google.com/group/Google-Maps-API/browse_thread/thread/7e6dd6d1d835
85d9/8fd177f6b5cde7c1?lnk=gst&q=extmaptypecontrol#8fd177f6b5cde7c1

Should be as simple as setting title attribute.

Reported here originally:
http://code.google.com/p/gmaps-utility-library/issues/detail?id=1

your code is well done, but with IE6 there is a small problem with dragging
(IE thinks you are selecting the page..).

To remove that, I make a little modification to your code. Simply

  GEvent.addDomListener(document, 'mousemove', function(e) {
    return me.drag_(e);
  });

LabeledMarker should follow same pattern as MarkerManager, in accepting a
parameter for the GMap2 object to add the overlay to.
(I discovered this as I had my map variable named differently and got an
error).

MarkerManager's constructor:

function MarkerManager(map, opt_opts) {
  me.map_ = map;

If someone already has some templates for jsdoc or jsdoc-toolkit, we should put 
them into svn.  
Otherwise, being able to auto-generate at least the reference documentation, 
would be nice.

I haven't put up the wiki page here yet for coding conventions, but they'll
basically be those that were followed in MarkerManager, e.g.:
- no tabs, 2 spaces = an indent
- function documentation, including params and return value

Those are the most important conventions.

- Need to add options to the DragZoomControl options example for
rightZoomOut, minBoxSize
- Add enableScrollWheelZoom to an example or create a new one
- Create an example that uses DragZoomControl on multiple maps


Need to do this before releasing next version of DragZoomControl.

This is a feature request.

Let's look at the example at http://gmaps-utility-
library.googlecode.com/svn/trunk/labeledmarker/1.1/examples/markerhider.htm
l

Here, you can see that several markers are put over each other so that you 
can't see their labels.

My idea was (well, it worked for some degrees but not perfect) that the z-
index should be increased if I move over a label with the mouse.

So you have do do this: Assign a mouse over handler to all labels (if you 
wish to) and set the z-index of the image and label text to a high value 
when inside it. When leaving the marker just set it down to the original 
value.

With this it should be easy to read all the markers in your example (and 
in my application, of course ;).

What do you think?

JOERN

This is just an idea, I'm not sure how useful it'd be.

Some developer would like to re-use these MyMaps icons:
http://www.visual-case.it/cgi-bin/vc/GMapsIcons.pl

There could be a createKmlIcon function that'd just take in a constant or
string (RECREATION or 'recreation' e.g.) and it'd return the full icon.

It wouldn't save that much time in coding, but it'd make it more obvious to
developers that its OK to use the icons.

I first need to make sure it is OK, however. :)

If your calling program uses global variables "center", "rect",
"polyBounds" or "zoomLevel", then using dragzoom.js changes the content of
those variables.

If your page contains HTML elements that use those names as "id" values,
then MSIE will crash in a manner that's rather difficult to debug.

http://groups.google.com/group/Google-Maps-API/browse_thread/thread/1c9627af52ae
126b/0e331d032aa88d74?lnk=raot#0e331d032aa88d74

All this could be avoided if dragzoom.js user "var center", etc.

What steps will reproduce the problem?
1. Marker with autoPan: true
2. Marker added to a MarkerManager with trackMarkers: true
3. Drag the marker of the map passed a couple of tiles

What is the expected output? What do you see instead?
Expect the map to stop panning and marker to drop after the mouse-button is
released. Instead the marker jumps out of view and the map keeps panning,
even after the mouse-button is released

What version of the product are you using? On what operating system?
Google maps v2.87, tested in FF2.0 and IE7.0 on XP

Please provide any additional information below.
Demonstrator at http://horse607.googlepages.com/test287.html 

Enhancement request for DragZoom:

I would like to be able to activate DragZoom and select the region in one step 
by right clicking and 
dragging the mouse. This would eliminate the need to click a button to activate 
DragZoom before 
selecting the region and would be much more convenient. This can probably be 
done by hooking 
into the singlerightclick event somehow.

What steps will reproduce the problem?
1. Load the maximize example - http://gmaps-utility-library-
dev.googlecode.com/svn/trunk/extinfowindow/examples/maximize.html
2. Click on the marker
3. Click on the maximize button
4. Click on the minimize button

What is the expected output? What do you see instead?
The maximize and minimize buttons should at an equal height with the close 
button.
Instead, after step 3, the minimize button is placed too low - at an equal 
height with the former 
(minimized) location of the close button.
After step 4, the maximize button is placed too high - at an equal height with 
the close button 
when the window is maximized.

Observed in at least Safari 3 and Firefox 3.

If you place a marker then move it via setLatLng(latlng) it won't move the
label as well.

What steps will reproduce the problem?
1. create markermanager and use addMarker() method with a third argument
opt_maxZoom like this.
  mgr.addMarker(point, 14,19);
2. marker added by this method is not shown at zoom level 18-19.
3. Change static constant MarkerManager.DEFAULT_MAX_ZOOM_ to 19, the marker
will be shown at zoom level 18-19.

What is the expected output? What do you see instead?

The marker added by addMarker(point,14,19) is shown at zoom level 18-19.

What version of the product are you using? On what operating system?

markermanager version 1.0 and FireFox 2.0.0.14.

Please provide any additional information below.

Often, users will try to 'cancel' a dragzoom operation by resizing their
selected rectangle to a point. Instead of not zooming, the map in fact
zooms the maximum amount.

Attached is a patch against r522 that:
 * Adds a new option, 'opts_other.minDragSize' specifying a minimum size in
pixels for the dragged rectangle. The default is 0 (current behaviour) but
something like 3-5 is sensible for most cases.
 * Ignores a zoom if the rectangle is smaller than minDragSize.

What version of the product are you using? On what operating system?
1.0

Please provide any additional information below.

The following should be added:

function LabeledMarker(latlng, opt_opts){
....
this.title = this.opts_.title || ""; 
....


LabeledMarker.prototype.initialize = function(map) {
....
if (this.title != "")
     this.div_.title = this.title;
....

What steps will reproduce the problem?
1. Load prototype.js as well as markermanager.js
2.
3.

What is the expected output? What do you see instead?
Some functions of markermanager.js do not work

What version of the product are you using? On what operating system?
Latest version

Please provide any additional information below.

What version of the product are you using? On what operating system?
Version 1.0

Please provide any additional information below.

The following methods are missing as they are defined in the normal 
GMarker:

 LabeledMarker.prototype.hide = function () {
   GMarker.prototype.hide.apply (this, arguments);
   if (this.div_)
      this.div_.style.visibility = 'hidden';
   }

 LabeledMarker.prototype.show = function () {
   GMarker.prototype.show.apply (this, arguments);
    if (this.div_)
       this.div_.style.visibility = 'visible';
   }

What steps will reproduce the problem?
1. Create a map with a DragZoomControl with rightMouseZoomOutEnabled.
2. Attempt to zoom out by right-dragging

What is the expected output? What do you see instead?
A zoom box following the mouse is expected.  Instead, the zoom box never 
expands.

Please use labels and text to provide additional information.
No mousemove event is fired during a right-drag.  Middle-dragging does work, 
however.
Demonstrator at http://gmaps-utility-library-
dev.googlecode.com/svn/trunk/dragzoom/examples/rightmousezoomout.html

> What steps will reproduce the problem?
1. Put a map fullscreen (<div id="map" style="width: 100%; height:
100%"></div>, with body width and height 100%)
2. Enable the drag zoom
3. The overlay is not positioned correctly

> What is the expected output? What do you see instead?
The overlay has to fit tha map, but it has a margin on top

What version of the product are you using? On what operating system?
Mozilla Firefox on Mac OS X


Please provide any additional information below.

I solved this simply adding css property top: 0 for the div "gzoom-map-cover":
DragZoomUtil.style([zoomDiv], {position: 'absolute', display: 'none',
overflow: 'hidden', cursor: 'crosshair', zIndex: 101, top:0});

I hope it's correct..

What steps will reproduce the problem?
1. Implementing a Google Map page in the same manner as below.

What is the expected output? What do you see instead?
A loaded Google Map with the Traffic and Traffic Help button. I see no map
data, but the container for the map. I also see the copyright line and the
GoogleBar at the bottom of the map but no overlay controls (zoom, pan, 

What version of the product are you using? On what operating system?
google.maps 3.x, does the same for the 2.x branch as well, via the jsapi
google AJAX module loader.
Server is Ubuntu Server 7.x with Apache 2.x.
Clients are Windows XP SP2 with FireFox 2.x and IE7/IE8. Also Mac 10.3 and
10.5 using FireFox 2.x and Safari 1.3 (10.3) and 3.0 (10.5).

Please provide any additional information below.
Link to the webpage in question:
http://emborsky.homelinux.com/sandbox/ExtMapTypeControl.php
Link to the source code of said page:
http://emborsky.homelinux.com/source?file=sandbox/ExtMapTypeControl.php

What steps will reproduce the problem?
1. Start Opera 9.25
2. Go to
http://gmaps-utility-library.googlecode.com/svn/trunk/extinfowindow/release/exam
ples/simpleExample.html
3. Click on marker

What is the expected output? What do you see instead?

Expected output: ExtInfoWindow popping up.
Bug: nothing happens (see error console of Opera and discussion at
http://groups.google.com/group/Google-Maps-API/browse_thread/thread/4734d86a79f0
1b08)

What version of the product are you using? On what operating system?

Opera or higher on any operating system.

Please provide any additional information below.

What steps will reproduce the problem?
1. Create two maps on a page, each with a drag-zoom control
2. One won't work.

What is the expected output? What do you see instead?

Expected: Both work independently
Actual: The 2nd triggers the 1st, and only the 1st works.

Please provide any additional information below.

This is due to the DragZoom widget using 8 html IDs for various nodes. The
attached patch fixes this behaviour. 

"It looks like GMarkerManager dynamically adds/removes markers when you
move/zoom your map. It would be great to have corresponded events (add and
remove events) to increase efficiency of AJAX calls (to request data for
newly added markers only) and to maintain a list of currently visible
markers (may be a public property to such list of visible markers can be
provided)."

We need to look into the best way to do this. 
The list of currently visible markers should be easy, and the first thing
to provide.

LabeledMarker could be improved by adding a routine which would allow an 
application to 
dynamically change the text of a label. This could be in response to a change 
in a preference 
setting check box, for example.

The fix is simple, add this function to the LabeledMarker Class:

LabeledMarker.prototype.setLabelText = function( newText ) {
    this.labelText_ = newText;
    this.div_.innerHTML = newText;
}


Also related to LabeledMarker 1.1, I notice that the show() and hide() routines 
alter the visibility 
style property.  I've always felt that it is best to alter the display property 
instead for showing 
(display: anything) and hiding (display: none) -- this should improve 
performance if you have 
lots of markers because the browser, when rendering a page, will ignore a 
display:none label div 
completely instead of having to calculate the size of the space to allocate for 
each 
visibility:hidden div.

However, I'm not sure what the show and hide code for a standard marker looks 
like -- I 
suppose if this code alters the visibility property, the code for 
hiding/showing the labels should 
follow suit. Or maybe the marker code should be changed??

The MarkerManager doesn't work when using the Ajax maps api.
References to "G" namespace classes makes it fail.

Errors: GBounds is not defined.
me.getMapGridBounds_ is not a function


/Claus

What steps will reproduce the problem?

var m = new LabeledMarker(new GLatLng(40.677956,14.765912),
{"icon": icon,"clickable": true,"labelText": "5","labelClass" :
"nongeo","labelOffset": new GSize(-3, -27)});

m.copy();


Exception is thrown in copy function ( looking for this.opt_opts_ which
doesn't exist).


1.1 on IE7.

Works by replacing this.opt_opts: with this.opts_

It might be worthwhile to implement an open source version of the loader API 
for our project.  Now 
there are about seven different libraries included in this project, so adding 
in some versioning a la 
the official Maps API might also be worthwhile.  This might also make 
integrating with the other 
Google JavaScript APIs easier. (See Issue 24)

An adaptation of the MarkerManager weather demo is attached using such a 
theoretical loader and 
namespace in combination with the Google loader.

Finally, backwards compatibility is important, as we've encouraged folks to 
link directly to the svn 
trunk.  Initially, a loader could essentially do the same, but implementing a 
versioning scheme 
and/or encouraging folks to link to /tags/ or something similar seems like a 
better idea.

MapIconMaker.createMarkerIcon() should allow for a new option to control
the transparency of generated icons.  This will allow developers to create
transparent map markers (useful for fade in/out effects).

I have attached a patch for mapiconmaker.js to add this feature.

What steps will reproduce the problem?
1. call map.enableScrollWheelZoom() BEFORE creating and adding a
DragZoomControl 

What is the expected output? What do you see instead?
expected normal behaviour, but the whole dragzoom tool feels like it's
offset by 40 pixels (downwards)


What version of the product are you using? On what operating system?
current trunk src, os x, firefox (but is consistent across browsers/os AFAIK

Please provide any additional information below.

- Need a test of addMarker
- Need a test of markers added near the prime meridian (e.g. New Zealand)

Tests should go in examples directory in future releases.

Originally reported here:
http://code.google.com/p/gmaps-utility-library/issues/detail?id=5

What steps will reproduce the problem?
1. Create and load marker to Marker Manager.
2. Execute hide() on marker.
3. Execute refresh() on Marker Manager

What is the expected output? What do you see instead?
Marker have to be hidden but it shows up.

What version of the product are you using? On what operating system?
Latest Marker Manager (1.0). Windows Vista.

Please provide any additional information below.
I am using Firefox 2.0.0.14 and 3.0 beta 5.


****

I'm pretty sure I've fixed this in the past (in local versions). I believe
we just need to do something like check if a marker isHidden before
removing it, set a flag on the marker (marker.mm_hideLater), and then hide
it next time we add it.

Reported in group:
http://groups.google.com/group/Google-Maps-API/browse_thread/thread/a07d17dee877
e80f/802582f0e417e7c9#802582f0e417e7c9

Currently using document.onselectstart to get rid of funky highlighting in
IE. This is too general however, and turns off selecting for entire page.
We need a more restrictive solution.

What steps will reproduce the problem?
1. Add 10 markers to the manager
2. remove 5 of the markers
3. call getMarkerCount

The out put should be 5 as only 5 markers remain in the manager however the
out put is 10

Using Release version, firefox 3.0, Windows Vista Business


Looking at the source for MarkerManager the numMarkers_[ZOOM] array whihc
is used to track the number of visible markers is not updated when
removeMarker is called.