ovsrobot / pw-ci Goto Github PK

Some shell scripts have bashisms in them when they include #!/bin/sh. Instead of removing the bashisms I suggest changing #!/bin/sh to #!/bin/bash

Example: https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/

Recheck-request: github-robot was requested twice, but both times only ovn-kubernetes workflow was actually re-checked, while checks in patchwork were updated as if both workflows was re-checked.

If one of the emails never arrived or the submitter messed up the set while sending, pw_mon will check on it every time and it will never be marked as completed. For example, ovsrobot still waits for a patch 1/2 to arrive for the 3-years old set https://patchwork.ozlabs.org/project/openvswitch/list/?series=269592&state=* and about 35 other similar sets, making 36 unnecessary requests to patchwork.

Retiring the set if the date is older than a month and the series is still incomplete might be a reasonable option. The series API has a "date" field.

Barring that, at least a way to re-submit a job.

GitHub allows to re-check failed jobs and not re-check those that succeeded. If that would be a default behavior of recheck-request feature, that may save a lot of CI time and will also eliminate the probability of infinite re-checks when a different job fails on every re-run.

@dceara do you think this will be useful for OVN?