ovotech / meters4s Goto Github PK

I don't have hard proof for this, but from my understanding several calls to micrometer contain locks and should be wrapped in blocking instead of delay.

Example:
https://github.com/ovotech/meters4s/blob/master/core/src/main/scala/com/ovoenergy/meters4s/Reporter.scala#L312

This delay calls after some indirection the following method in micrometer:
https://github.com/micrometer-metrics/micrometer/blob/54f89f40743937a5a78fb57eb0ddb6b2e6238be4/micrometer-core/src/main/java/io/micrometer/core/instrument/MeterRegistry.java#L598

This contains a synchronized block over meterMapLock and can block the current thread. Therefore I would argue that this could lead to blocking one of the io-compute threads if several calls hit the lock in parallel.