`--compile` flag doesn't respect `--outfile` when bundling `.node` files about bun HOT 14 OPEN

@jackyzha0 looks like there's a bug where the outfile is becoming the basename instead of the directory, so --outfile=dist/foo becomes foo

from bun.

working as intended. --compile sets --target=bun and some other flags, as it is not possible to use --compile without them set.

from bun.

Why is this working as intended? The --compile flag should raise an error if it fails to build the binary

from bun.

Is it failing to build the binary? --compile supports .node files

from bun.

Why is this working as intended?

The error is due to the default value of --format (browser), see

To load node files, set target to "bun"

With --compile, this is flipped to --target=bun

It seems this is not clear and documentation and error messages should be revised.

from bun.

Yes, it fails to emit the binary. This still happens with --target=bun, let me see if I can put together a minimal repro for yall

from bun.

Ah it actually does seem to compile properly but it doesn't seem to respect --outfile

from bun.

https://github.com/jackyzha0/bun-compile-repro

from bun.

thank you for the reproduction. this specifically only happens when a node file is included

from bun.

hey, any pointers on where I can look to maybe submit a PR for this?

from bun.

build_command.zig line 297, in that code block i suspect this might be.

may be worth checking if this happens without --compile. seems likely since the absolute outfile is already decided it might not actually be, not 100% sure.

StandaloneModuleGraph.zig line 525 might be the wrong directory

from bun.

Confirmed that this bug was not present in v1.0.23 or v1.0.24 (but only on Mac OS??) bug seems to affect only Linux from my tests so far. Let me backdate a few versions to confirm

from bun.

var output_dir = this_bundler.options.output_dir;
if (outfile.len > 0 and output_files.len == 1 and output_files[0].value == .buffer) {
    output_dir = std.fs.path.dirname(outfile) orelse ".";
    output_files[0].dest_path = std.fs.path.basename(outfile);
}

I suspect it might be here (L299 in bun/src/cli/build_command.zig)? For including .node files, output_files.len > 1 so this path to properly set output_dir never gets hit?

hm nvm that doesn't seem to be it

from bun.

spent a few hours looking at it but couldn't figure it out :( would appreciate if yall could help take a look when you get the chance!

from bun.