was sending 0.001 at https://bridgetozora.world and finally got
https://goerli.etherscan.io/tx/0x94596956b3d7ab6cb8c779b4e5fde4e16d36ca4335d554b6f84ececda0234d8d

Created an NFT but that's all.

1. Can't mint it more than once.
2. Can't change the theme.
3. can't go to "Single Edition"
4. Can go to "Drop collection", choosing folder but can't go forward...
   
   
   
   

Tx : 0xbaf37d3cc2bf1eee8f20ed404b85217a87b4b727f6384220c0c14b31c41273f8
0x8181a5b70a93e8e51591dcf2b395522a70fdb5135d3b87ef1bb3779b16d10e64

https://bridgetozora.world/
I'm trying to bridge at address and it keeps giving contract error. Gas price is market price but error.

Create a gas-limited EIP165 handler for curator auction approval.

Given makersplace doesn't properly handle ERC165 plus a few older 721 contracts should we just skip this check?

This comment should be buyer fns?

1. Set start and end time
2. Allow for setting a custom extension period for coldie-style end period

Are there plans to update Offers.sol to support collection wide offers?

Hello, I used your testnet, you used an easy and understandable interface.
But different tokens can be added in the bridging network
I believe that this project can come to better places.
I wish you success in advance, I hope to see you in beautiful places

Hello.
Do you have contracts to support for Sepolia network for asks and offers.

https://github.com/ourzora/v3/tree/main/addresses

check both approvedOperator and isApprovedForAll here? To prevent needing a individual approval through a proxy contract creating the auction.

Summary

If we want to participate in the security vulnerability portion of the community audit, what communication method does the @ourzora team prefer? 💭

Reconciling differences

In the Enter Zora V3, I see that the Community Bug Bounty section says to email either of these addresses:

We have an up to 25 ETH community bug bounty for any vulnerabilities discovered. If you find any vulnerability that could result in the loss of user funds or NFTs, reach out to [email protected] or [email protected]

However, the Community Audit section of this README isn't particularly clear on whether or not we should be emailing those addresses, commenting directly in the PR, or taking another method. 😅

🐦 Twitter Equivalent of this issue: tweet

Summary

Starting with a fresh clone of 479e45c, changing directory into the repo, running yarn to install dependencies, and running yarn build throws this error:

"Error occured: _h.match is not a function"

$ git rev-parse HEAD
479e45ccf29b2c9fe48cdf60373212c45c060e56

$ yarn
yarn install v1.22.15
[1/4] Resolving packages...
success Already up-to-date.
$ husky install
husky - Git hooks installed
Done in 0.26s.

$ yarn build --show-stack-traces
yarn run v1.22.15
$ forge build && yarn typechain --show-stack-traces
compiling...
no files changed, compilation skipped.
$ typechain --target=ethers-v5 'dist/artifacts/*/*.json' --out-dir dist/typechain --show-stack-traces
Error occured:  _h.match is not a function
Stack trace:  TypeError: _h.match is not a function
    at extractBytecode (/workspaces/v3/node_modules/typechain/dist/parser/abiParser.js:217:70)
    at Ethers.transformAbiOrFullJsonFile (/workspaces/v3/node_modules/@typechain/ethers-v5/dist/index.js:55:58)
    at Ethers.transformFile (/workspaces/v3/node_modules/@typechain/ethers-v5/dist/index.js:30:21)
    at runTypeChain (/workspaces/v3/node_modules/typechain/dist/typechain/runTypeChain.js:54:82)
    at async main (/workspaces/v3/node_modules/typechain/dist/cli/cli.js:49:20)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Investigating the trace 🔎

I grep'd for this function call:

$ grep -rn "_h.match" .
./node_modules/typechain/dist/parser/abiParser.js:217:    if ((_h = json.bytecode) === null || _h === void 0 ? void 0 : _h.match(bytecodeRegex)) {

Here's the full expression in context:

    if ((_h = json.bytecode) === null || _h === void 0 ? void 0 : _h.match(bytecodeRegex)) {
        return extractLinkReferences(json.bytecode, json.linkReferences);
    }

I pulled up packages/typechain/src/parser/abiParser.ts at main and I think this is the source:

  if (json.bytecode?.match(bytecodeRegex)) {
    return extractLinkReferences(json.bytecode, json.linkReferences)
  }

I tested this out on two local machines, ensuring that Foundry is installed for both:

• Ubuntu 20.04.3 LTS
• Mac OS Monterey v12.2.1

Would love a pointer for how to get yarn build working on my machine! 🙇‍♂️

making the constructor arguments immutable will help with gas savings for deployment and is slightly cleaner code

Summary

stopPrank()'s annotation cites prankStart() at the end:

However, prankStart() doesn't exist beyond this citation: startPrank() does! 😉

Removed for security reason.

It looks like the source code and comment don't match. Update the comment?

Need to solve small visual bug:
Connected to https://testnet.zora.co/
I clicked the menu in the upper right part of the site - a black drop-down profile menu appeared on the screen (your balance, etc.)
then I click the Personalize link, I get the Personalize menu on the right side of the screen, but the profile drop-down menu remains in place. Need to fix this.

Hi @ourzora!

Is there a calendar or public roadmap of upcoming Community Audits? 💭

After reviewing #126, I'm curious about when the next Community Audit is so I can come prepared.

In the meantime, I'll read through the existing Draft / RFCs and take notes.

Thank you! 🌞

Most of the Zora-V3 contracts are using require statements for reverting errors. Which is not a very gas-efficient way to revert errors. The require statements stores Strings which costs a lot of Gas (deploying + function Calling & Reverting).
And as the protocol aims to be Gas Efficient, Then it would be much better to not use require statements to revert the errors.
Instead, use Custom Errors. Which is a new solidity feature (introduced in 0.8.*)
Custom errors do the same thing but cost much less gas than the require statements.
For more info read this

Thanks,
AB Dee

There is a persistent user interface problem that has been hindering me from accessing any NFTs which were created via pre-Create "mint" function for 1/1 editions such as .txt and .md files, and my personal profile page, for almost a month now.

It affects market dot zora dot co links with exceptions at time. Several other friends have reported encountering the same problem across both Chromium-based, and other types of browsers both on desktop and mobile.

I hope this is the right place open this issue.

the page structure is quite colorless, you can work in the background a little more, it also cuts the bridge fees from the metamask wallet 2 times

when creating a collection on the zora testnet network when it's finished and clicking "view mint page" it occurs a link error but when going to the profile and check on the zora testnet collection section it works fine

this addres i am using to test : 0x1216Fcc0e9fDD122872429Ec1DE3970174C1C053

One way to save 2 slots would be to limit the size of a few fields to a more reasonable number.

Duration can easily be uint32 (probably not a great idea to have an auction beyond 100 years etc).

uint32+uint16+address is still less than uint256 (one storage slot)

firstBidTime and startTime can both be uint126 to save one slot as well

address
uint16 finderFeeBps
uint32 duration
uint128 firstBidTime
uint128 startTime

saves two slots over the current configuration.

Originally posted by @iainnash in #122 (comment)

Safemath isn't needed for solidity ~0.8

Example: https://ethereum.stackexchange.com/questions/17718/what-is-the-point-of-zeppelins-safemath-sol

I tried to bridge gETH to Zora testnet, 3 times.
First 2 trying was on default setting, sending 0.1 ETH and paying gas fee suggested,
After second Failure, I changed bridging amount and gas fee, which were 0.11 ETH and aggressive gas fee.
But I could not complete again bridging.

Here are three HXs that were not completed.

• https://goerli.etherscan.io/tx/0xdb391e3d907385146e456252bbe1796acc9b65ae5218d59287cdc691a3488c5b
• https://goerli.etherscan.io/tx/0x757bcdb0db946994338c1fd224fe25c094a307fcec6d98de9be530125646dc42
• https://goerli.etherscan.io/tx/0xf4406c96c10294e86f98b5c658bd85e30350b50d72ff5f2865a8a3b3af7eca3e

Would it make sense to check for a zero curation fee here (in the case that the address of the curator is the same as the auctioneer)

Summary

🔬"recieve" is misspelled. Proposed quick fix: s/recieve/receive