ourzora / nouns-protocol Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
There is a bug in MetadataRenderer.sol in the _generateSeed function which impacts psuedo-randomness:
blockhash(block.number)
will always return0x0000000000000000000000000000000000000000000000000000000000000000
, since the hash of the current block cannot be known when the transaction is being executed.
Instead, blockhash(block.number - 1)
should be used.
If you have no bid increment and reserve price of 0 no bids can be placed
Seems unlikely in practice.
Provide an option to export the current set of delegated addresses. Usually, when we get token holders this is the actual set we want. Etherscan and others provide a naive balance of tokens.
Run forge test -vvv
with no skips and it seems to work locally on osx but fail remote on linux?.
The contract addresses that are deployed in the tests are different which makes the strings generated in the metadata not match.
Currently, in Governor.sol the _castVote function takes in the following:
function _castVote(
bytes32 _proposalId,
address _voter,
uint256 _support,
string memory _reason
) internal returns (uint256)
This covers:
1.) A user who doesn't have a token (reverts)
2.) A user who has a token
3.) A user who is delegated tokens
however: what if a delegated voter (ex. an autonomous agent) wanted to make a vote only for a specific token holder? This doesn't cover that case.
It would be good IMO to add another param that is used to get the votes originally belonging to someone. So say Tom delegated 5 votes to an AI agent, and Sally also gave 5 votes, the ai can vote separately for each person. There would also have to be a check to make sure that the given address has delegated to the voter (ai agent)
In the case the param is 0x000... do the same logic that we have now.
Let me know if there are any questions, or if there are better approaches to this. Really excited about everything Nouns and would love to do this!
To use for storing metdata
image
description
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.