Git Product home page Git Product logo

Comments (3)

clinty avatar clinty commented on May 25, 2024

(this is not true of all videos)

from c2play.

OtherCrashOverride avatar OtherCrashOverride commented on May 25, 2024

This stems from the many different ways subtitles are encoded. There are two strategies currently implemented:

  1. Subtitles coded with a start and end time
  2. Subtitles coded with a start time but no end time. An empty subtitle buffer is send when its time to remove them.

There appears to be a need for third strategy which I am open to suggestions:
3) Subtitles coded with a start time and no end time. No empty buffer is sent.

Currently, in the absence of an end time, the subtitle will display for 10 minutes. I could probably display these until the next subtitle happens or a duration shorter than 10 minutes happens.

from c2play.

OtherCrashOverride avatar OtherCrashOverride commented on May 25, 2024

This commit changes the default timeout to 2 seconds for subtitles that do not specify a display duration.
0a1bc8e

It tested well with the only two test files I have. If there are additional problems with this strategy, feel free to reopen this issue or start a new issue, but please provide a sample file that illustrates the issue.

from c2play.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.