ostdotcom / ost-price-oracle Goto Github PK

• Below command was not running test cases. It's showing 0 passing
  truffle test test/contracts/price_oracle/
• Let's fix it and integrate with .travis.yml

The PriceOracleInterface used by PriceOracle.sol should come from openst-payments.

duplicated error code l_ci_po_spd_3 is l_ci_po_spd_5 "Zero Price is not allowed" https://github.com/OpenSTFoundation/ost-price-oracle/blob/master/lib/contract_interact/price_oracle.js#L145

For PriceOracle (and interface, where appropriate), the following changes should be made:

• rename tokenDecimals function to decimals (to be consistent with EIP20)
• update PRICE_VALIDITY_DURATION description/documentation to reflect that the value is in block numbers

for v0.9.2 document in code comments that it is (always silently) understood as [quoteCurrency/baseCurrency] and be explicit in function naming

For PriceOracle:

• remove events from PriceOracle.sol as they are inherited from the interface
• correct documentation of expired event from "when price expires" to "if price has expired"