osoc20 / urban-brussels-api Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 0.0 35.18 MB

See `oSoc20/urban-brussels` repository !

Home Page: https://github.com/oSoc20/urban-brussels

License: MIT License

TypeScript 100.00%

urban-brussels-api's People

Contributors

Stargazers

Watchers

urban-brussels-api's Issues

Fix searching with full streetname

/search with full streetname search is not working, however partial streetname is working

Number of styles per postal code

Related to oSoc20/urban-brussels#18

Autocomplete: Make streetname unique

Currently, some streetnames are duplicated in the autocomplete list because city is different.

🥁 Battle plan

Landing page routes
- Fun facts #16
- Random buildings
Building lists
- Search #18
Building details page
- Details #19
Dashboard
- ...

Fix "class" in fun facts

Don't put a tag on the building name, we can't search for it !

urban-brussels-api/src/facades/funFacts/index.ts

Line 79 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--type tag--small tag--no-margin">${row.building}</span>`) 

urban-brussels-api/src/facades/funFacts/index.ts

Line 126 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--style tag--small tag--no-margin">${row.building}</span>`) 

urban-brussels-api/src/facades/funFacts/index.ts

Line 167 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--style tag--small tag--no-margin">${row.building}</span>`) 

urban-brussels-api/src/facades/funFacts/index.ts

Line 262 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--architect tag--small tag--no-margin">${row.buildings_name}</span>`) 

Change class "architect" by "style".

urban-brussels-api/src/facades/funFacts/index.ts

Line 284 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--architect tag--small tag--no-margin">${row.styles_count}</span>`) 

Change class "architect" by "typology"

urban-brussels-api/src/facades/funFacts/index.ts

Line 303 in 4944e9a

 fact = fact.replace('{0}', `<span class="tag tag--architect tag--small tag--no-margin">${row.typologies_count}</span>`) 

Number of buildings per "typo"

Number of buildings per architect

Related to oSoc20/urban-brussels#16

Netlify serverless ?

https://www.heroku.com/ could be another solution.

Wist je dat het gebouw Manufacture Royale de pianos François Berden et Cie - Confiserie Chocolaterie Antoine de volgende typologieën heeft: burgerwoning, werkplaats (ambachtelijk), tentoonstellingszaal, fabriek en herenhuis.
& Wist je dat het gebouw Scholencentrum Sacré-Coeur de Lindthout de volgende typologieën heeft: orgel, school, conservatorium/kunstacademie, kasteel en kerk/kathedraal/basiliek.
& Wist je dat het gebouw Maria Assumptalyceum en Basisschool, Ecole Primaire en Lycée Maria Assumpta en Institut Christ-Roi de volgende typologieën heeft: kinderbewaarplaats, school, pastorie, parochiezaal en kerk/kathedraal/basiliek.
& Wist je dat het gebouw Josaphatpark de volgende typologieën heeft: kiosk, sportcomplex, fontein, Zitbank, brug en beeldhouwwerk en herdenkingsmonument.
& Wist je dat het gebouw Voormalige hoofdzetel van S.A. Les Tramways bruxellois de volgende typologieën heeft: burgerwoning, kantoorgebouw, bijgebouwen, gelijkvloers met handelszaak en herenhuis.
& Wist je dat het gebouw Brusilia de volgende typologieën heeft: pompstation, sportcomplex, appartementsgebouw, winkel en warenhuis/supermarkt.
=> the typologies in these fun facts are grey boxes that lead to the building list but don't actually add to the search
-- @jbelien : Moved (back) to Front-End : oSoc20/urban-brussels#65

Wist u dat er een gebouw is met 46 verschillende bijdragers ? Dit gebouw is Gemeentehuis van Sint-Gillis.
=> The building name here links to the iris monument page instead of our own detail page for it. (This is also the only building name that links to anything, so either link every building name or none?)

undefined
=> Even when I wait this still stays, but might have something to do with clicking on a fun fact tag, going to the building list and then just going back in my browser instead of clicking home (because the home button is not published yet)
-- @jbelien : Moved (back) to Front-End : oSoc20/urban-brussels#62

Less of an issue:
Wist u dat het gebouw Abdij van Dieleghem - voormalige prelaatwoning dateert van 1775, waardoor het één van de oudste gebouwen in Brussel is.
=> building name can link to detail page (has no links now) + maybe also create a tag for years? Or is search on year not enabled right now?
-----> Building name can't link to detail page since there is no specific page for each building
-----> Search by year put on TODO list

~~Inconsistencies between 'Wist u' and 'Wist je' for the Dutch fun facts (can be 'wist je dat' overall imo)~~

Make route 'info'

GET
    /info/<type>/<id>
        { lang: 'fr' }
        { all of infos }

GET
/stats/
...coming soon

GET
/fun-facts
    { lang: 'fr' }
    [
        { fact: 'yo to' },
        { fact: 'yo te' }
    ]

request: the language
response: 2 fun facts

POST
/search
    request: { lang: 'fr', type: 'style', value: 'Jean-Bon VIIc', limit: 10, offset: 20 }
    response: {
        [
                { id: 3b5eea1d-d825-4cd9-9a18-63e0cc2afed4, ...infos }
        ],
        show: 1,
        results: 35
    } 35/10  => 4



GET
/search/random
    request: { lang: 'fr', limit: 10 }
    response: {
        [
            { id: 3b5eea1d-d825-4cd9-9a18-63e0cc2afed4, ...infos },
            { id: 3b5eea1d-d825-4cd9-9a18-63e0cc2afed4, ...infos }
        ],
        show: 2,
        results: 2
    }

osoc20 / urban-brussels-api Goto Github PK

urban-brussels-api's People

Contributors

Stargazers

Watchers

urban-brussels-api's Issues

Recommend Projects

Recommend Topics

Recommend Org