"Raiffeisenbank" is miscategorized as fuel not bank about name-suggestion-index HOT 6 CLOSED

Similar problem for "dm": iD uses supermarket instead of chemist. Both are in name-suggestions.json, so one could argue that it's a bug in how iD creates presets out of it. But on the other hand I guess that it would be best if name-suggestion-index wouldn't include too many alternative tagging versions.

Here is a list of all names that are currently present more than once in name-suggestions.json:

• 7-Eleven
• ABC
• Adler
• Auchan
• Biedronka
• Boston Market
• BP
• Canadian Tire
• Carrefour
• Carrefour City
• Carrefour Express
• Casey's General Store
• Casino
• CBA
• Centra
• Chevron
• Circle K
• Citgo
• Coop
• Coop Jednota
• COOP Jednota
• Costcutter
• Deichmann
• Delikatesy Centrum
• dm
• Dollar General
• Edeka
• Esso
• Franprix
• Fressnapf
• Honda
• Intermarché
• Jet
• Jimmy John's
• Konzum
• Kum & Go
• Kwik Trip
• Lewiatan
• Mercator
• Mobil
• Morrisons
• Papa John's
• Petit Casino
• Peugeot
• QuikTrip
• Raiffeisenbank
• Renault
• Sainsbury's
• Sainsbury's Local
• Sam's Club
• Shell
• Spar
• SPAR
• Społem
• Statoil
• Stewart's
• Super U
• Tchibo
• Tesco
• Tesco Express
• The Co-operative Food
• Volg
• Walmart
• Walmart Supercenter
• Wawa
• Woolworths
• Автозапчасти
• Дикси
• Магазин
• Магнит
• Мария-Ра
• Монетка
• Пятёрочка
• Радуга
• Стройматериалы
• Теремок
• Хозтовары
• Шиномонтаж

from name-suggestion-index.

Yeah we need to improve the search on iD. I think I did that on purpose to not return too many results.

• This issue: openstreetmap/iD#2000.
• I started on it here: https://github.com/openstreetmap/iD/tree/improved-search but don't know when I'll get back to it.

from name-suggestion-index.

Oh I guess I fixed this today in 941ee1d88c1e44bea399d82c8a9bce016ee866d1.
It now picks the name suggestion with the highest count, not the first one that appears in name-suggestions.json.

"Raiffeisenbank" is a bank now!

from name-suggestion-index.

Nice @bhousel, I think I still need to fix it here. Not sure what the data says; if this actually exists in OSM or if this script is messed up somewhere.

from name-suggestion-index.

I'm assuming the data probably actually exists in OSM that way.. I did see a bunch of convenience stores flip from amenity=fuel to shop=convenience after the change. It's a better suggestion because places like 7-Eleven only sometimes sell gas.

from name-suggestion-index.

As far as I can see, this is an issue with the way name-suggestion-index is consumed, not a problem with the data we're generating. I'm therefore closing this issue.

from name-suggestion-index.