Git Product home page Git Product logo

Comments (5)

mnalis avatar mnalis commented on September 18, 2024 1

I'd guess the quick fix for this particular problem would be that website does not match country as pl but as "pl instead - "pl" (with the trailing quote) would produce even less false positives, but would also prevent matching things like "gb-sct".


However, it seems that https://nsi.guide/ website only does the simplest matching for that country in entered, i.e. if you entered specific country code, it won't match:

  1. things that are present it whole world - e.g. searching for amenity=parcel_locker in pl will not find GLS, even if it has [{"include":["001"]}] (i.e. whole world)
  2. any other UNM_49 numeric codes (like e.g. "039" for Southern Europe)
  3. manually defined polygons as in that example, wikidata QIDs, and other more complex cases like e.g. that specific one peoples_united_bank_ct.geojson

While the first (whole world) could be added relatively easily manually, second is noticeably harder, and third near impossible.

I'm not sure if implement just 1. would make it less confusing, although it would cover many popular cases. Wiki lists @ideditor/location-conflation which perhaps could be used for more complete country-matching support.

How much work that would be implementing that (including detecting country polygon crossing manually specified polygon to get full support), I don't know... Perhaps UI should then be changed so that instead of typing a country code, you pick a single point on the map, and it finds all polygons that this point is inside...


What is more confusing to me is why it is showing you "People's United Bank" which is marked as dissolved, and you have not checked "Dissolved" checkbox.

from name-suggestion-index.

matkoniecz avatar matkoniecz commented on September 18, 2024

What is more confusing to me is why it is showing you "People's United Bank" which is marked as dissolved, and you have not checked "Dissolved" checkbox.

It also confused me - but this checkbox causes NSI to list solely dissolved ones. If I understood it right.

from name-suggestion-index.

bhousel avatar bhousel commented on September 18, 2024

Yeah - nsi.guide is really just a site I threw together. It's not like a fully featured "product".

I think when I originally made it, the index was still using country codes, and we hadn't switched to using the locationSet yet (which supports sub-country regions and other include/exclude situations).

from name-suggestion-index.

peternewman avatar peternewman commented on September 18, 2024

I think this is just a duplicate of #4077 isn't it?

from name-suggestion-index.

matkoniecz avatar matkoniecz commented on September 18, 2024

Yep, duplicate of #4077

from name-suggestion-index.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.