oskarkook / proxy-form Goto Github PK

It would be good if the library could support or provide examples of using reducers for form updates. This can be useful in some more complicated use-cases.

Should be named getRawForm() in this case.

• Code
• Documentation
  • API
  • Describe usefulness in docs

Should provide some easy integration for validation and errors. Take a look at react-hook-form for inspiration.

It causes issues with Typescript that are difficult to resolve. A replacement could be to allow the following:

field(prepareMyField(form.myField))

However, this would require that we check correct useForm() usage through call stack tracing. See #4 (comment)

• Variable in context that stores which identifier was last used to access form (everytime a field is accessed, the context is notified)
• When field() is called, it checks that the identifier of the field is the same as the last access

Could use the yup API docs as an influence: https://github.com/jquense/yup#api

Similar to changed fields, but instead is registered whenever user interacts (focuses) the field.

See https://codesandbox.io/s/sad-darkness-2ff50?file=/package.json

Either expose an onSubmit() function, or just expose the getForm() function. The latter seems better to me, would also be helpful in some edge cases.

The getForm() function should be renamed to getValues() or something. It would match up with the defaultValues option and would be clear that it's not a proxy that you're receiving.

When a deletion or swap in an array happens, Immer produces the following patches:

1. If elements are swapped, there is a replace patch
2. If last element is deleted, the length element is patched
3. If any element before the last one is deleted, there is additionally a replace patch with the next element as the new value

Possibly, the following patches should be emitted instead:

1. move operation as described in the JSON patch RFC
2. remove operation on the last element of the array
3. remove operation on the given element of the array

Need to write a large number of tests to ensure correctness.. 😅