origintrail / node-interface Goto Github PK

I'm unable to use the node profile website for any deposit/withdrawal of xdai. I suspect because I can see the polygon hub address being used when I pick the xdai option at the start. It just doesn't load up anything after I enter my identity.

But... I can't diagnose it because this doesn't install on windows and I don't have a linux dev machine.

I'm likely going to have to write my own website for deposit/withdrawal at the moment it seems so I can deposit again on xdai.

npm install

> [email protected] preinstall C:\Users\Luke Skinner\Source\node-interface-master\node_modules\web3\node_modules\web3-providers-ws
> rm -rf node_modules/websocket/.git

'rm' is not recognized as an internal or external command,
operable program or batch file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] preinstall: `rm -rf node_modules/websocket/.git`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

(Reported on https://node-profile.origintrail.io/)

A user on Discord has used the "Deposit ETH to your Operational Wallet" feature without entering either a ERC 725 Identity or Operational Wallet.

The code at

According to the documentation at https://web3js.readthedocs.io/en/1.0/web3-eth.html#sendtransaction

If you don't provide a "to" address (which would be the operational wallet the user didn't enter) it does a contract creation transaction. As far as I can see there's no way of reclaiming the ETH sent to this contract because the contract code is hard coded to "0x" when it sends the transaction.

I think the login screen should make ERC 725/Operational wallet mandatory. The depositEth() method should also have a safety check on null/empty addresses. I could maybe write up the fixes for this at some point but I'm not familiar with vue.js.

Not really related to the code but the user lost a small amount of ETH here, I can provide details privately if needed.