ordnancesurvey / osdatahub-js Goto Github PK

I've tested this endpoint a bunch of different ways:

https://api.os.uk/features/ngd/ofa/v1/collections/${collectionId}/items?key=${apiKey}&bbox=${extent.join(',')}&bbox-crs=http://www.opengis.net/def/crs/EPSG/0/3857

The results are completely random? Attaching image from OS' code sandbox:

Not understanding why only some buildings are selected, it should be all within the bounding box, limited to 100, not sporadic.

There are multiple instances of 'integrer' which should be 'integer' within the documentation.
Cases generally occur in the API examples section.

It's really easy to forget to build the docs!

Please advise on the use of the API key. Regardless of the application examples I find, the key is always embedded directly in the code in plain text. This is absolutely insecure, especially considering the fact that there is no way to restrict the key's actions by domain name.

How can the key be safely used in open systems? Is there a way to limit the key by domain name?

The media/browser_examples_screenshot.jpg references the old basemap tiles prior to the addition of the OS Maps API.
Let me know if you'd like me to update this 🙂

Good afternoon

1. Have deployed OS NGD API – Features Retrieve items from a feature collection, I noticed that https://labs.os.uk/public/osngd/os-ngd-api-features/examples/queryables.html has the filters built into query, how do I update my app to include these filters?
   

2. Where in the code do I change the location of bbox? (greyed out)
   

Thanks for making code open source really helpful in development of building-height.co.uk
Building-Height is a system that can determine the attributes of historical buildings in England. The building part can be defined just by uploading a photo.
If you would like to try the app here is a link to an example image in Farnham, Surrey. (currently only have a couple thousand OS polygons footprints in our database for testing.

For queries that complete fully (total number of features is under the feature return limit), the total number of returned features appears to be incorrect (lower than expected). This could be due to either:

1. The incorrect variable being passed as the final feature count,
2. Failure to run the log command before the final page of results has been added to the temporary accumulated response object.

The test Collections Endpoint Passes w/ collectionId within ngd/ngd.test.js is failing due to updates to the NGD's schema. Whilst this has minimal impact on the user, the test is written to expect the old schema response (bld-fts-buildingline); this response will now be bld-fts-buildingline-1.

(Advisory) Potentially need to update the contact email for the package.

Currently, the osdatahub-js browser example uses OSM as the basemap. For consistency, change the basemap to the Ordnance Survey Maps API.

Be sure to use a locked down api key since it will be public

Provide a version of osdatahub for use in the web browser:

1. Minify the codebase
2. Use browser-native fetch capabilities, instead of node-fetch
3. Distribute via CDN (?)

The following documentation corrections are required:

1. (Installation) First import statement uses curly brackets, there are not required.
2. (Getting Started) Example references a BBox but only provides two array components (a point feature)
3. (Contribute) GitHub Issues href currently links to osdatahub-py

Add functionality to integrate the OS NGD Features API:

1. Add support for bbox spatial queries
2. Provide capabilities to optionally pass a CQL filter to the API
3. Provide efficient paging capability (via the links >> next component of the API response body) to the handler