Bug Description, Steps to Reproduce, Crash Logs, Screenshots, etc.

Hello.
First of all, thank you for making a good library.
I found something while using the functions of the library, so I left a post.

I didn't want to keep passing the variable isMenuPresented to the subview with Binding for MenuBarExtraAccess, so I tried to use it wrapped in an ObservableObject.
However, using it in this way caused menubar to close and open abnormally slow (state -> binding is normal)
Below is the code of the way I implemented it.
Is Presented for controlling MenuBarExtraAccess, but is ObservableObject hard to use?

class AppState: ObservableObject {
    @Published var isMenuPresented: Bool = false
}

struct MyApp: App {

@NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate
@StateObject var appState = AppState()
        
        MenuBarExtra("ListeningDogApp") {
            MenuBarExtraView()
                .environmentObject(appDelegate)
                .environmentObject(appState)
        }
        .menuBarExtraStyle(.window)
        .menuBarExtraAccess(isPresented: $listengDogAppState.isMenuPresented) { statusItem in // <-- the magic ✨
            // access status item or store it in a @State var
        }
}

    struct PreferencesView: View {
        
        @EnvironmentObject var appDelegate: AppDelegate
        @EnvironmentObject var AppState: AppState
        @State private var isHovered = false
        
        var body: some View {
            
            Button {
                appState.isMenuPresented = false
                appDelegate.showMainWindow()
            } label: {
                HStack {
                    Text("Preferences...")
                    Spacer()
                }
                .frame(height: 30)
            }
            .buttonStyle(.plain)
        }

Bug Description, Steps to Reproduce, Crash Logs, Screenshots, etc.

Hi there, first of all thank you for MenuBarExtraAccess!

Problem: my macOS app starts showing high CPU/mem usage possibly after computer is awaken from sleep. Profiling indicates some good amount of time spent on NSStatusItem.

I think it might be the way I'm using MenuBarExtraAccess. I'm reproducing it consistently putting the computer to sleep and then clicking on the app in the menu bar. Edit: now I'm able to consistently trigger it by simply clicking on the app in the menu bar, don't even need to put it to sleep.

Would appreciate any help or pointers you may have. Code and profiling screenshots can be found below.

Environment

Environment: macOS Sonoma 14.2.1, MBP M1 2020, one external monitor
System settings: menu bar auto-hide enabled

Code

This is sample code that very closely resembles how my app uses MenuBarExtraAccess and MacControlCenterUI:

import SwiftUI
import MacControlCenterUI
import SettingsAccess

@main
struct MyAppApp: App {
    @NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate: AppDelegate
    @State var isMenuPresented: Bool = false

    var body: some Scene {
        Settings {
            SettingsView().environmentObject(appState)
        }

        MenuBarExtra() {
            MenuBarView(isMenuPresented: $isMenuPresented)
                .openSettingsAccess()
                .environmentObject(appState)
        } label: {
            Label(Constants.appName, image: "MenuBarIcon")
        }
        .menuBarExtraStyle(.window)
        .menuBarExtraAccess(isPresented: $isMenuPresented)
    }
}

import SwiftUI
import MacControlCenterUI
import Combine
import OSLog

struct MenuBarView: View {
    @Environment(\.openSettings) private var openSettings
    @Binding var isMenuPresented: Bool

    @State private var counter: Int = 0
    @State private var isCounterEnabled: Bool = false
    @State private var timer: AnyCancellable?

    func update() {
        // Update counter every second only when the UI is being presented
        counter += 1
    }

    func startTimer() {
        timer = Timer.publish(every: 1, on: .main, in: .common)
            .autoconnect()
            .sink { _ in update() }
    }

    func stopTimer() {
        timer?.cancel()
        timer = nil
    }

    var body: some View {
        MacControlCenterMenu(isPresented: $isMenuPresented) {
             VStack {
                 Toggle("Enable", isOn: $isCounterEnabled)
                 Text("\(counter)")
             }
        }
        .onChange(of: isMenuPresented) { _ in
            if isMenuPresented {
                if isCounterEnabled: {
                    startTimer()
                }
            } else {
                stopTimer()
            }
        }
    }
}

Screenshots

52.28 s 36.8% 1.00 ms -[NSStatusItem _updateReplicantsUnlessMenuIsTracking:]

MenuBarExtras.setupEventsMonitor

statusItem.for(:)

Thank you for creating this library, it is incredibly useful.

I am new to SwiftUI and have been conducting some experiments, I encountered an issue when I changed the default @main struct MyApp: App to @main final class MyApp: App. The MenuBarExtraAccess ceased functioning. When I reverted back to the original code, it started working again.

Hello,

First of all, thank you for the package! I have an app called Wunderbar that shows words on the Menu Bar to help people to learn new words. I'm using Timer to change the words after certain period of time. Sometimes some words are too long and some users are using MacBook with a notch, therefore the words become invisible on the Menu Bar.

I was looking for a solution for the problem and I've found your package. Unfortunately, when I started to test the package, I realised that it is not working as expected for my use case. I really appreciate if you can somehow fix the issue or let me know if I'm doing something wrong.

Here is a way to reproduce the issue:

@main struct MyApp: App {
    @State var isMenuPresented: Bool = false
    @State var text: String = "very very very long text here so the MenuBarItem is not going to be visible on the Menu Bar"
    
    var body: some Scene {        
        MenuBarExtra() {
            
        } label: {
            Text(text).onAppear {
                Timer.scheduledTimer(withTimeInterval: 3, repeats: true) {_ in 
                    text = "short"
                }
            }
        }.menuBarExtraAccess(isPresented: $isMenuPresented) { statusItem in
            print(isMenuPresented)
        }
    }
}

Output of the print statement:

false
false // after 3 seconds

Somehow we are observing the visibility change of the item but the value is not set to true when the item becomes visible. Also, statusItem.isVisible is always true whether it is visible or not.