Git Product home page Git Product logo

android-messages-desktop's People

Contributors

ahmetcetin avatar ajivoin avatar aliveinadream avatar bradmurray avatar candbot avatar chrisknepper avatar dependabot-preview[bot] avatar dependabot[bot] avatar dhitchcock avatar epicnesstwo avatar imgbotapp avatar jacob-swenson avatar jjgalvez avatar larivierec avatar lyramsr avatar orangedrangon avatar racingjayson avatar rasa avatar restyled-commits avatar scoronado12 avatar shareefalis avatar vanowm avatar vityaschel avatar yochananmarqos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

android-messages-desktop's Issues

No Notification Image in Windows 10

Describe the bug
When a notification comes through, the letter of the person's name is shown, but not their image. Also, the bottom of each notification has: "pw.kmr.android-messages-desktop" which didn't appear before

To Reproduce
Steps to reproduce the behavior:

  1. Receive a text
  2. View notification

Expected behavior
See image in the notification that appears when app is open (and don't see pw.kmr.android-....)

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Version 4.3.0

electron-builder on Windows OS

Following installation instructions via yarn add electron-builder --dev will add electron-builder into node_modules of the package, not as system executable. Because of that yarn dist script fails, since it assumes electron-builder is installed into system.
So wouldn't it make sense to use electron-builder that comes with the package instead?

    "dist": "yarn build && ./node_modules/.bin/electron-builder --config electron-builder.js",

Cache for avatars is not needed

Just ran a quick benchmark:

for(let i = 0, loop = 10, l, s, e, r, node, avatar:HTMLCanvasElement|null, name, nodes = document.querySelectorAll("[data-e2e-is-unread]"); i < nodes.length; i++)
{
	name = nodes[i].querySelector("[data-e2e-conversation-name]")?.textContent || "";
	avatar = nodes[i].querySelector("canvas.canvas-avatar");

	s = new Date().getTime();
	for(l = 0; l < loop; l++)
	{
		r = cacheManager.getProfileImg(name);
	}
	e = new Date().getTime();;
	console.log("getProfileImg", e - s);

	s = new Date().getTime();
	for(l = 0; l < loop; l++)
	{
		r = avatar?.toDataURL();
	}
	e = new Date().getTime();
	console.log("   toDataURL", e - s);
}

testing each function call 10 times for each contact, the difference is so insignificant, that it's not worth it (numbers in milliseconds):

image

(10000 calls however does add up to about 2 seconds difference)

Also the cache system potentially can show incorrect avatar if a contact changed their avatar, or if during first call the avatar wasn't fully loaded.

* I am not sure the cache is necessary anymore but there are rumors that canvas.toDataUrl is slow.

Tray Menu Recent Contacts

Describe the solution you'd like
The Android Messages app offers "most recent contacts" when you hold down the app's icon. Would it be possible to find the most recently messaged names in the webview and add them to the tray menu?

Settings Module Rewrite

Is your feature request related to a problem? Please describe.
Settings are messy and hard to use and modify.

Describe the solution you'd like
Custom solution probably using observables. Open to other thoughts. I am not enjoying how the current settings module types everything.

Snapcraft Publication

Is your feature request related to a problem? Please describe.
This project offers snap packages, but is not published on the Snapcraft store.

Describe the solution you'd like
Publish the project on the Snapcraft store.

Additional context
I've never had to install a .snap file before, and every time I do, it fails to install. I think offering the snap through the snap store will reduce confusion and make this project more user friendly to install.

macOS doesn't check for updates

Describe the bug
The 'Check for updates' in menu does not work and no dialog box to tell if there are updates or not.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Menu AndroidMessages'
  2. Click on 'Check for updates'
  3. Wait for a few seconds
  4. Nothing appears on screen

Expected behavior
It should have a message saying if there are new updates or not, and if there are a redirect link for the website download page of the new version.

Desktop (please complete the following information):

  • OS: macOS
  • Version 10.15.7

Filename format for saved images

Currently filenames of saved images are random, would be nice if date used instead and even user's name appended to it (optional)
On Android they are saved in following format:

IMG_YEARMONTHDAY_HOURMINUTESSECONDS

Can't drag Android Messages by title bar in macOs Big Sur

When Android Messages is in the foreground, you can't drag it around the screen by click-hold the title bar.

To Reproduce
Steps to reproduce the behavior:

  1. Install macOs Big Sur
  2. Install and hook up to your messages
  3. bring to foreground
  4. Click on the title bar and attempt to drag the window.
  5. Bring another window in front of the messages window, then click the messages window title bar, and you are now able to drag.

Expected behavior
Window should be draggable while in the foreground

Screenshots

I've got a little screen recording of the problem if needed, but it wont upload to the ticket.

Phase out deprecated electron-hunspell

Is your feature request related to a problem? Please describe.
I recently noticed electron-hunspell is deprecated and there is an official electron solution now. In the future I would like to work towards adopting this.

4.3.0 on Big Sur - "You do not have permission to open the application"

Describe the bug
When installing 4.3.0 in Bug Sur, I get the message "You do not have permission to open the application". Right clicking on the app in finder and selecting Open does not allow me to bypass (this method worked when I downgraded to 4.2.0)

Desktop (please complete the following information):

  • OS: Big Sur
  • Version 4.3.0

Updater uninstalled old version but didn't install new version

Describe the bug
There was an update notice telling me that the app will update after exit. But the updater only uninstalled the old version but didn't install the new version

To Reproduce
Steps to reproduce the behavior:

  1. Notice the update notification
  2. Exit the app
  3. Wait for some minute
  4. Notice that the app was deleted but there isn't a new version installed

Expected behavior
The new version should be installed.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version 20H2

macOS Big Sur changes in iconography

macOS Big Sur introduces changes in macOS iconography, namely the specification that all icons should be rounded squares. This application should be updated to support this new specification.
I have included a mockup of what a potential Big Sur icon could look like, if maintainer wants I'll adjust according to preferences and upload source files for it. I'm willing to do all the design work to make this happen, I'd like it to match the other icons on my dock e.g. Facebook Messenger.
android-messages-macosbigsur

Google Fi Integration

Issue:
Google Fi was recently integrated into Android Messages instead of using Hangouts as the default messaging app. The Messages app provides a link to sign in with your email address, but then I get an error that I am not using a supported browser. I can use the old way of signing in with the QR code, but then I lose the extra features that I would get with using my Google Fi account.

Solution:
Enable signing in with my Google Fi account. Not sure what it would take to become a "supported browser" within the app?

Alternatives:
None that I can think of.

Screenshot:
image
image
image

Infinite Loading Animation on Startup

Is it just me, or as of yesterday this version of AMD is no longer working?
It shows QR code, but after login, it get stuck at loading conversation list.
image

I've tried roll back source and compiled versions, none work for me.

The original 3.1.0 is still working though.

Windows 10

impossible to move window on macOS Catalina and Mojave

Describe the bug
It's impossible to move window on macOS Catalina and Mojave

To Reproduce
Steps to reproduce the behavior:

  1. Mouse left click on the bar of application,hold and move mouse.
  2. Its not moving

Expected behavior
Move application

Desktop (please complete the following information):
macOS Mojave and Catalina (Propably also Big Sur)

Tray Menu Icons

Known bug that the icons do not show up until the conversation list changes once after launch.

Installed on Windows 10 - get a Javascript error

Hi - I just installed this on Windows 10 Pro, and I'm getting the below error:
error

I've tried both the portable version as well as the installer, both give me the same error.

After I close the error, Android Messages says that it's running (I can see it in my task Manager), but it isn't in my taskbar or anything like that.

Thanks

Error when trying to run Android Messages Desktop from source

Describe the bug
I have forked and cloned the repo then I did a yarn install and yarn start. Once I started it the program started but only displays the dev tools and not the app itself. There is the following error message in the console.
image

Relevant Info
node v15.6.0
yarn v1.22.10
electron v11.2.1
OS: Arch

To Reproduce
Steps to reproduce the behavior:

  1. Clone repo
  2. yarn install
  3. yarn start

Expected behavior
The app starts correctly

Desktop (please complete the following information):

  • OS: Arch
  • Version rolling

Notification Dot

Is it possible to have the icon on taskbar flash and or add a notification dot, it would be extremely helpful

KDE System tray dedicated Icon No Longer Appears After Javascript Pop-Up Error Fix

Hi there,

Before the JavaScript pop-up error fix, Android-messages use to have its own dedicated icon app that sat in KDE's System Tray. This allowed for its own app Pop-up messages (the one that eventually got the javascript error) and you didn't have to have the app minimized to keep it open. Click on the system tray app once, the app appeared, again, it disappeared. It would just remain silently working in the background essentially letting the task bar icon/app do its thing.

That is no longer the case with when your fix went into place. Now there is no dedicated System Tray icon, and I have to keep the app minimized to work, constantly bringing it up or down to see it. It now uses KDE's notification system, which is not ideal (disappears within 10 seconds and I have to sort through all the notifications to find Android-messages.) Is there anyway to bring back the dedicated system tray icon with its functionality?

I am running KDE Manjaro stable, if that helps. Your for is now listed in AUR.

How to properly test/compile application and sync with git in this repo?

It seems this repo is missing some scripts from original repo, hens can't use the same commands to test and compile actual application as per instructions in original readme

npm start is as far as I'm able to go with this.

Also, after npm install it adds a bunch of new files into the directory of the repo, how do we handle them to sync any changes we do to the code via git?

(Sorry, total newbie here)

Any suggestions? Thanks.

"Android Messages is ready" notification

Describe the bug
I get the "Android Messages is ready" notification every time I get a new message. I thought I was getting this instead of the normal notifications (nothing showing the new message content) but I seem to be getting both, but the "is ready" notification persists while the rest go away.

Expected behavior
Just the notification with the contact name and message content (I assume the "is ready" notif is for once the app is linked?).

Desktop (please complete the following information):

  • OS: Pop!_OS 20.10
  • Version 5.1.1

Merging multiple branches into one is a nightmare

As suggested I've been creating a new branch for each new feature.
So I decided test them all together by creating a test branch for each and merge them all together...what a nightmare that turned out to be. Each merge would delete modifications in the same file from previous merges...I had to track each single modification manually...

Is there anything better could be done about it?

P.S.
combined patches

recieving pairs of identical notifications

Describe the bug
Pairs of duplicate notifications on dunst for all received messages. Other applications do not exhibit the same behavior.

To Reproduce
Steps to reproduce the behavior:

  1. Launch android-messages-desktop.
  2. Receive an SMS message.
  3. Receive two identical notifications by the dunst notification server.

Expected behavior
Only receive a single notification per message.

Desktop (please complete the following information):

  • OS: archlinux
  • Version: 5.7.4-arch1-1

Additional context
I have verified that only one instance of dunst is running and that other other applications are not exhibiting this behavior.

Should there be an auto updater?

There have been some murmurs of dislike over the current implementation of the auto updater (a feature I have not worked on or personally use).

Should it be removed until I can dedicate time to put some work into it?

Please vote with the reactions.

Set urgency hint on new messages

Is your feature request related to a problem? Please describe.
I have to check the app to see if there is new messages, instead of knowing from a highlighted window

Describe the solution you'd like
Window urgency hint was set on new messages.

Additional context
I'm using i3 on linux. I made a simple change but I don't think it is comprehensive

urgency-hint.txt

last update will not open and run on mac with big sur

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

No notifications

Similar to that of #158 (I wanted to create a new post, as its a different bug), I am not getting notifications on Pop OS, based off of Ubuntu 20.10

I notice that there is no listing of the application within the notification settings, so I think the issue may stem from there. I have the notifications turned on through the application

The icon in the status bar does change when I get a text, so I know it is getting the update, it just isn't sending the notification to gnome

Other than this issue, this application works perfectly! Keep up the great work!

(Question/Build possibilities)

Any possibility to build armv7l and aarch64?

I was able to get it running on a pi4 in dev mode and I'm currently attempting to build an armv7l rpm for SailfishOS (they have issues with US provider MMS. This and Google Fi web texting/mms solves that).

Build attempts seem possible given I got it working on the pi4 with Raspbian, by bypassing yarn dist, editing electron_builder.js and instead using yarn build && USE_SYSTEM_FPM=true yarn run electron-builder --linux rpm --armv7l.

Would appreciate any build guidance.

macOS menu bar icon incorrect resolution/scaling

next to other menu bar icons, the resolution is clearly incorrect and appears highly pixelated
perhaps you have not included a 2x scale icon for retina display support?
I have attached a screenshot of my menu bar, with the icon on the far left of other correctly scaling menu bar icons
this bug affects me running macOS Big Sur, presumably this affects other macOS versions as well
Screen Shot 2020-11-19 at 6 53 22 PM

Windows 10 Notification Image Generation

On windows 10 the notification image fails to be created somehow. It works for images that do exist in the dom. I assume it is a problem with paths and where to save them.

App won't register in Windows 10 notification settings

Describe the bug
I installed the windows version and the app doesn't show in the windows 10 notification settings menu (Settings > System > Notifications and actions). Since it isn't registering in that menu, I am also not getting toast notifications. However, my other programs are working such as Pushbullet for Chrome using native windows 10 notifications.

To Reproduce
Steps to reproduce the behavior:
Install, that's it

Expected behavior
Android Messages 5.0.0 should show in the notification settings where I can configure those options

Desktop (please complete the following information):

  • OS: Windows 10 20H2
  • Version 19042.868

Additional context
I tried running SFC scan and DISM. Uninstalling and reinstalling.
If I install the chrisknepper 3.1.0 version, it does show in the Notification and actions menu.

App name is a string

Describe the bug
In the notification pop-up, the app name is a string instead of "Android Message"

Expected behavior
Name: Android Message.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Version 5.1.1

Dark Mode

2021-01-26 18_06_12-Window

I use Drak reader and it is doing something funky to the app when my system shifts to dark mode on windows. If I toggle Dark Mode it looks fine. This only happened in the last week.

Thanks,

Notifications

Is it possible to get the notification banner changed to alert style? I don't see the app in my System Preferences --> Notifications settings.

How do you unhide the file menu?

I cannot find any documentation on the hotkey/shortcut to unhide the file menu.
Please share with me your wisdom.

Thanks in advance,

`Play notification sound` setting is broken

When Play Notification Sound is disabled not only it still plays sound, but it plays 2 different sounds instead: google web messages' sound and system's sound.

Windows 10

Portable version is not portable

A portable program supposed to keep all it's settings and any dynamic content within the same directory it's launched from. This way if it's launched from a portable device (flash drive) after application quit and drive removed, there wouldn't be any traces of the application left on the computer.

Current implementation of "portable" version stores settings in %appdata%/android-messages-desktop

Group Chat Icons in Notifications

Describe the bug
When a notification occurs from a group chat the correct icon is not generated/used.

To Reproduce
Steps to reproduce the behavior:

  1. Have notifications set to show content.
  2. Get a group chat notification.

Expected behavior
Generate the proper icon or use a generic placeholder.

Desktop (please complete the following information):

  • OS [All]
  • Version [4.2 and below]

Additional context
The origin of the bug is known I just need to fix it when I get the time.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.