Git Product home page Git Product logo

openid-client-server's Issues

Headers not being set on response

I work within EFWAE in Optum and was having an issue with the openid-client-server and was referred here by Alex Aavang.

While investigating why our react front end was seeing calls that should be JSON as XML I came across a possible bug within the server. The headers from node-fetch are key value pairs where the value is an array with a single value. The node response header method, res.writeHead expects these headers to be set as strings rather than arrays. This is not the case when performing a getUserInfo request to the OAuth provider but only happens with the response from our koa api.

Screen Shot 2020-12-01 at 4 36 54 PM

Adding the following code at the beginning of the sendResponse method in /middleware/util.ts resolves the issue as it converts the arrays into strings. Without these changes none of the headers seen in the response from the koa API are forwarded to the client.

if(headers.raw){ headers = JSON.parse(JSON.stringify(headers.raw())) }

This can also been seen in the network tab of the page using the server. As you can see the response does not have a content-type and is therefore seen as xml.

Screen Shot 2020-12-02 at 8 16 08 AM

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.