The opi-marvell-bridge's discuss from opiproject

opi-marvell-bridge's Issues

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

fix(deps): update github.com/opiproject/gospdk digest to dff04ee
fix(deps): update github.com/opiproject/opi-spdk-bridge digest to 457e5eb
chore(deps): update pre-commit hook renovatebot/pre-commit-hooks to v37.140.8
fix(deps): update module github.com/onsi/ginkgo/v2 to v2.15.0
fix(deps): update module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.47.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

fix(deps): update github.com/opiproject/opi-api digest to e44db26
fix(deps): update github.com/opiproject/opi-smbios-bridge digest to 898160c
fix(deps): update github.com/opiproject/opi-strongswan-bridge digest to 0a5ad56
fix(deps): update module github.com/vektra/mockery/v2 to v2.40.1
Click on this checkbox to rebase all open PRs at once

Detected dependencies

docker-compose

docker-compose.yml

redis 7.2.3-alpine3.18

jaegertracing/all-in-one 1.53.0

curlimages/curl 8.5.0

curlimages/curl 8.5.0

dockerfile

Dockerfile

docker.io/library/golang 1.21.6

alpine 3.19

docker.io/fullstorydev/grpcurl v1.8.9-alpine

github-actions

.github/workflows/codeql.yml

.github/workflows/commitlint.yml

.github/workflows/docker-publish.yml

.github/workflows/go.yml

.github/workflows/linters.yml

.github/workflows/release-please.yml

.github/workflows/scorecard.yml

.github/workflows/update-copyright-years-in-license-file.yml

gomod

go.mod

go 1.19

github.com/golangci/golangci-lint v1.55.2

github.com/google/uuid v1.5.0

github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.1

github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.0

github.com/onsi/ginkgo/v2 v2.14.0

github.com/opiproject/gospdk v0.0.0-20240108075015-92d689fff706@92d689fff706

github.com/opiproject/opi-api v0.0.0-20231204182835-b9900483c605@b9900483c605

github.com/opiproject/opi-smbios-bridge v0.1.3-0.20231209030245-a017fdaa0e05@a017fdaa0e05

github.com/opiproject/opi-spdk-bridge v0.1.2-0.20240113094845-ba494c746f2f@ba494c746f2f

github.com/opiproject/opi-strongswan-bridge v0.1.2-0.20231211064623-e4ef0e4fa95f@e4ef0e4fa95f

github.com/philippgille/gokv v0.6.0

github.com/philippgille/gokv/gomap v0.6.0

github.com/philippgille/gokv/redis v0.6.0

github.com/vektra/mockery/v2 v2.38.0

go.einride.tech/aip v0.66.0

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1

golang.org/x/tools v0.17.0

google.golang.org/grpc v1.60.1

google.golang.org/protobuf v1.32.0

pre-commit

.pre-commit-config.yaml

pre-commit/pre-commit-hooks v4.5.0

renovatebot/pre-commit-hooks 37.131.0

alessandrojcm/commitlint-pre-commit-hook v9.11.0

golangci/golangci-lint v1.55.2

Check this box to trigger a request for Renovate to run again on this repository

/opi-marvell-bridge flag redefined: port

after #70 I see

$ sudo docker run --rm -it -v /var/tmp/:/var/tmp/ -p 50051:50051 ghcr.io/opiproject/opi-marvell-bridge:main
/opi-marvell-bridge flag redefined: port
panic: /opi-marvell-bridge flag redefined: port

@PWAlessi assigning to you

Add otel for tracing

using otelgrpc.UnaryServerInterceptor()

See opiproject/opi-spdk-bridge#683

add all the namespaces to the controller inside the CreateNvmeController call

from @benlwalker comment #20 (comment)

Technically, a user could do this sequence of steps:

Create subsystem
Create namespace
Create controller
In this case, it needs to go add all the namespaces to the controller inside the CreateNvmeController call.