wrong detection for SLES 4 SAP in SLES12 and SLES15 SAP versions. about supportutils HOT 6 CLOSED

I change detectProducts like this:
detectProducts() {
OUT=$1
if rpm -q SLES_SAP-release &>/dev/null
then
log_write $OUT "#==[ System ]=======================================#"
log_write $OUT "# Product"
log_write $OUT "SUSE Linux Enterprise Server for SAP Applications"
log_write $OUT
log_cmd $OUT ls -lA --time-style=long-iso /etc/products.d/baseproduct
log_cmd $OUT rpm -qf /etc/products.d/baseproduct

And I reordered the function calls in basic_environment to put the /etc/os-release on top:
conf_files $BASIC_ENVF $RELEASE
detectProducts $BASIC_ENVF
detectVirtualization $BASIC_ENVF

from supportutils.

After further thought, I think these two commands should be directly in the basic_environment function.
We could use this output on any/all OS version.
log_cmd $BASIC_ENVF ls -lA --time-style=long-iso /etc/products.d/baseproduct
log_cmd $BASIC_ENVF rpm -qf /etc/products.d/baseproduct

ie:
basic_environment() {
# This is a minimum required function, do not exclude
printlog "Basic Environment..."
test $MIN_OPTION_ENV -eq 0 && { echolog EXCLUDED; return 1; }
addHeaderFile $BASIC_ENVF
get_customer_info $BASIC_ENVF
log_cmd $BASIC_ENVF 'date'
log_cmd $BASIC_ENVF 'uname -a'
RELEASE=$(ls -1 /etc/release)
detectVirtualization $BASIC_ENVF
conf_files $BASIC_ENVF $RELEASE
detectProducts $BASIC_ENVF
log_cmd $BASIC_ENVF ls -lA --time-style=long-iso /etc/products.d/baseproduct
log_cmd $BASIC_ENVF rpm -qf /etc/products.d/baseproduct

from supportutils.

The ls is a bit redundant with the rpm -qf, but I like the idea.

from supportutils.

The ls is a bit redundant with the rpm -qf, but I like the idea.

The "ls" here would let us see if there is a product mismatch between the file on disk and the rpm claiming to own the file.
Another bit of troubleshooting data.

from supportutils.

Some more product details in basic-environment to make product clear is useful, since os-release doesn't hint to SLES for SAP. But the ls of /etc/products.d/ already exists in updates.txt if someone need to troubleshoot that.

from supportutils.

Some more product details in basic-environment to make product clear is useful, since os-release doesn't hint to SLES for SAP. But the ls of /etc/products.d/ already exists in updates.txt if someone need to troubleshoot that.

Good point. problem solved!

from supportutils.