openshift-assisted / assisted-ui Goto Github PK

Steps to reproduce:

1. Just open the Facet initial page

Expected result:
There should be no any errors at the header

Actual result:
{ "error": null } at the header (please see the screenshot)

Should I use this repo, facet-lib, Jira, or a Google Doc somewhere to capture little nits like this? 🙂

Current

Proposed

Use fa-ban, listed here, for the status icon of disabled hosts. --pf-global--Color--200 would also be 👌.

While working on the OKD we noticed that the container fails to start on our system.

The log gave us the following error:
nginx: [emerg] socket() [::]:8080 failed (97: Address family not supported by protocol)

Further searching showed that it's indeed a known nginx issue, and the reason for it is that the base UBI8 nginx image contains a directive to specifically listen on IPv6.

Currently when deploying facet, it depends on an nginx config file to be mounted into the image so that the API service will get reverse proxied.

I propose that we permanently add a config template to the image and render it at runtime using environment variables. Currently, the only value it needs is the assisted-service URL.

Benefits

• Someone trying to run the image does not need to understand nginx configuration or even be aware that nginx is in use. Those are implementation details that can be handled within the container.
• The container's interface becomes simpler. Instead of needing to generate a config file (even if there is an embedded script to help) and mount that as a file or ConfigMap into the container at a specific path, the user can simply set an environment variable at runtime.
• The current approach does not work well when run outside a cluster. A user has to create the config file on their local filesystem and mount it into the container at runtime. This change would remove the need for that.

Details

A shell script will become the new ENTRYPOINT for the container image. That shell script will

1. render the template and put it into the right place. Possibly use envsubst or some other method for rendering
2. exec nginx with whatever args it needs

#22
Steps to reproduce:

1. Fill all required fields at the "1. Cluster setup" section
2. Click Next. Now you should be at the "2. Add hosts" section.
3. Click at the sidebar at a "1. Cluster setup" section or at a "3. Results" section

Expected results:
"2. Add hosts" should not be highlighted anymore in case if it is possible to navigate between sections.
In case if we shouldn't be able to navigate between all sections, all these other sections should be gray out and we shouldn't be able to click on them.

Actual result:
Two sections are highlighted at the same time (please see the screenshot)