openshift-assisted / assisted-installer-ui Goto Github PK

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L37C1-L39C135

Use this: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing/installing-on-any-platform#installation-approve-csrs_installing-platform-agnostic

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L93C1-L93C108

If this link is for the Assisted Installer guide, I recommend using the AI SaaS feedback link: https://issues.redhat.com/secure/CreateIssueDetails!init.jspa?pid=12341520&summary=Documentation+feedback&issuetype=1&description=Details:%0A%0ADocumentation+URL:%0A%0A&priority=10200&labels=hcidocs-feedback&components=12393573

If the link is to report a non-docs issue, feel free to close this issue.

in OCM (currently trying to switch to npm):

ERROR in ./node_modules/@openshift-assisted/ui-lib/build/cjs/common/components/ui/formik/LabelField.js 8:50-76

Module not found: Error: Can't resolve 'react-tagsinput' in '/container_workspace/node_modules/@openshift-assisted/ui-lib/build/cjs/common/components/ui/formik'

Same for @sentry/browser, 'axios', monaco-editor, etc...

Looking at the package.json file

"peerDependencies": {
    "@reduxjs/toolkit": "^1.9.1",
    "@sentry/browser": "^5.9 || ^6",
    "axios": ">=0.22.0 <1.0.0",
    "i18next": "^20.4 || ^21",
    "monaco-editor": "0.45.0",
    "react": "^17 || ^18",
    "react-dom": "^17 || ^18",
    "react-i18next": ">11.7.3",
    "react-monaco-editor": "^0.55.0",
    "react-redux": "^8.0.5",
    "react-router-dom": "^5.3.0",
    "react-tagsinput": "^3.20",
    "redux": "^4",
    "uuid": "^8.1",
    "yup": "^1.4.0"
  },

Most of these should be dependencies apart from react and react-dom

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L72C1-L87C93

I recommend that you replace the individual links to the various docs with a link to the new section on Operators in the AI guide:

Customizing your installation

If this is acceptable, I will create a permalink for the UI in the AI user guide.

This needs to be converted to the docs.redhat.com URL.

Fix use of history in the newClusterModal.tsx.

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L27C1-L29C120

Replace docs.openshift.com with docs.redhat.com link: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing/installing-on-bare-metal#installation-network-user-infra_installing-bare-metal

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L45C1-L45C29

Change domain from access.redhat.com to docs.redhat.com

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L54C4-L54C108

https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing/installation-configuration#installation-special-config-kargs_installing-customizing

The Bare Metal Inventory heading seems to have disappeared recently.

Expected (old screenshot)

Current (in prod)

ui-lib has peerDependency for redux toolkit ^1.9.1
But uhc-portal (OCM) uses ^2.2.2.

Is it necessary for ui-lib to have that peerDep?

➜  uhc-portal git:(master) ✗ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @reduxjs/[email protected]
npm ERR! node_modules/@reduxjs/toolkit
npm ERR!   @reduxjs/toolkit@"^2.2.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @reduxjs/toolkit@"^1.9.1" from @openshift-assisted/[email protected]
npm ERR! node_modules/@openshift-assisted/ui-lib
npm ERR!   @openshift-assisted/ui-lib@"2.32.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/jschuler/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jschuler/.npm/_logs/2024-06-27T16_52_05_210Z-debug-0.log

https://docs.redhat.com/en/documentation/assisted_installer_for_openshift_container_platform/2024/html-single/installing_openshift_container_platform_with_the_assisted_installer/index#vsphere-post-installation-configuration_installing-on-vsphere

https://github.com/openshift-assisted/assisted-ui-lib/blob/22cbeb0325542af3569218888b8764a51d82cda2/src/ocm/components/clusterWizard/ClusterWizardStepHeader.tsx#L3

This link looks like it does not belong in docs_links.ts.

Add GitHub actions for PRs

https://docs.redhat.com/en/documentation/assisted_installer_for_openshift_container_platform/2024/html-single/installing_openshift_container_platform_with_the_assisted_installer/index#nutanix-post-installation-configuration_installing-on-nutanix

https://github.com/openshift-assisted/assisted-ui-lib/blob/ac3d80854d7ee0e8bc2f5696185661ccbf8b9628/src/cim/components/Agent/tableUtils.tsx#L122

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L62C1-L62C261

This URL will break if the doc version number changes and a specific redirect is not in place.

Please use an attribute for the version number to avoid maintenance issues.

After installing a cluster, copying kube-admin's password doesn't work on HTTP settings for OKD.
This forced me to copy the password from the network logs through devtools.

Since HTTP is common on self deployed setups and assisted installer supports HTTP, I think that either

1. Support copy.
   But PatternFly doesn't seem to have any plans on supporting HTTP clipboard copy.
   ClipboardCopy

2. Add a button that reveils the value as plain text

3. Atleast alert the user that HTTP copy isn't supported and offer a workaround

If you guys can decide on a viable solution, I think I can contribute on a fix.

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L21C1-L23C123

Issues to fix:

• docs.openshift.com is in the process of being decommissioned. access.redhat.com is going to be replaced by docs.redhat.com, which is now live. Therefore, all docs.openshift.com links should be replaced by docs.redhat.com links: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing/installation-configuration#installation-special-config-encrypt-disk_installing-customizing. You should define an attribute for the version number (4.15) to simplify maintenance.
• 4.12 version. Is there a reason why we should link to 4.12 when it will soon be EOL?

We recently upgraded OCM-UI application to PF5 and since OCM-UI is using @openshift-assisted/ui-lib@^2.29.0 PF4 and PF5 libraries are co-living and generating estrange behaviours or console errors

"@openshift-assisted/[email protected]":
  version "2.29.0"
  dependencies:
...
    "@patternfly/react-core" "^4.168.8"

See for instance https://issues.redhat.com/browse/OCMUI-124

Is this upgrading on your backlog? any due date for it?

Many thanks!

Since https://issues.redhat.com/browse/MGMT-7787 is already implemented we should be able now to remove this function and consume its functionality from within the provider implementing the feature support level.

https://github.com/openshift-assisted/assisted-ui-lib/blob/5e6951917760e4f5c40049806302c1b45110943b/src/common/components/clusterConfiguration/utils.ts#L91

https://github.com/openshift-assisted/assisted-installer-ui/blob/322630e1276b254cfc10619d749f98cd5e46bf45/libs/ui-lib/lib/common/config/docs_links.ts#L78C1-L82C41

Because multicluster engine has specific additional resource requirements, depending on the storage operators and cluster type, I recommend that you create a link to this section: Resource requirements

https://github.com/openshift-assisted/assisted-ui-lib/blob/22cbeb0325542af3569218888b8764a51d82cda2/src/ocm/components/clusterWizard/ClusterWizardStepHeader.tsx#L17