openresty / meta-lua-nginx-module Goto Github PK

Let's do this in meta lua module for the stream version:

diff --git a/src/ngx_stream_lua_common.h b/src/ngx_stream_lua_common.h
index f727943..8bb7503 100644
--- a/src/ngx_stream_lua_common.h
+++ b/src/ngx_stream_lua_common.h
@@ -43,8 +43,8 @@
 #endif


-#if !defined(nginx_version) || (nginx_version < 1006000)
-#error at least nginx 1.6.0 is required but found an older version
+#if !defined(nginx_version) || (nginx_version < 1013006)
+#error at least nginx 1.13.6 is required but found an older version
 #endif

Can we use ngx_*_lua_shdict as a third party moduel, which applies for shdict from nginx. We can uses FFI to share memory to http module and stream module, instead of http or stream using its own memory only

See

diff --git a/src/api/ngx_stream_lua_api.h b/src/api/ngx_stream_lua_api.h
index c2a7764..9c1d08f 100644
--- a/src/api/ngx_stream_lua_api.h
+++ b/src/api/ngx_stream_lua_api.h
@@ -21,7 +21,7 @@
 /* Public API for other Nginx modules */


-#define ngx_stream_lua_version  10012
+#define ngx_stream_lua_version  4


 typedef struct {

The dev branch should die and get renamed to master.

What is the status of the meta module in respect to the http module.

A diff between the generated output of the meta module for the http subsystem and the http modules committed files shows many differences. After a few fixes to the meta module (e.g splitice@b4a3d6c) output it does compile, it does not however pass tests.

Perhaps the README should be extended with some documentation as to the current status?

Let's make mini-tt2 generate a block comment at the beginning of each output C file which states that the file was automatically generated from the path of some .tt2 file and should never be edited directly by hand and etc.

The word "subsystem" is too long and too heavy and appears so many times in all the templates and directory and file names. Let's abbreviate it to "subsys". Also, there is all-upper-case form like the SUBSYSTEM tt2 variable.

Some compilations units like shdict.c, string.c, lex.c, regex.c, and etc, could share the object code directly between http and stream modules in the final nginx executable. We could simply make the http and stream lua module depend on this meta lua module not only at codegen time, but also at compile and link time :)

Let's make mini-tt2 emit C line control macros to the C output like below:

#line 32 "src/http/ngx_http_lua_foo.c.tt2"

So that it would be easier to debug any compilation errors or runtime C backtraces directly in the template files.

Right now, make SUBSYS=xxx always generate code into build/src/, this is not desired. Better make it possible to specify a DESTDIR variable.

For now, we should have at least basic sanity checks that makes sure the templates are syntactically correct. We can also execute ngx-relang against the generated files once we are confident they all satisfies NGINX's coding styles.

I compiled a list of commits from ngx_http_lua that are not yet ported to this module (excluding the currently opened PRs):

ngx_http_lua master branch (last updated: 2019/08/27 - ngx_http_lua HEAD: 9b22495)

• openresty/lua-nginx-module@2a19073 (change: removed error logging on coroutine runtime errors)
• openresty/lua-nginx-module@9a892b8 (bugfix: coroutine.wrap propagate errors to the parent coroutine)
• openresty/lua-nginx-module@97f0101 (feature: enabled 'ngx.thread' and 'ngx.socket.udp' in ssl_session_fetch_by_lua*)
• openresty/lua-nginx-module@97431d8 (bugfix: fix compilation with NGINX cores < 1.11.11)
• openresty/lua-nginx-module@189ba24 (feature: log location of timer funcs that fail to run)
• openresty/lua-nginx-module@8573c1c (feature: ngx.pipe shutdown when light thread waiting)
• openresty/lua-nginx-module@c5135a0 (change: removed compat for NGINX core < 1.6.0)
• openresty/lua-nginx-module@947fa00 (change: retired old CFunction API)
• openresty/lua-nginx-module@60736e6 (change: 'resty.core' is mandatorily loaded)
• openresty/lua-nginx-module@a96e99a (change: prevent PUC-Rio Lua compilation)
• openresty/lua-nginx-module@2f27064 (bugfix: fixed file cache key size alloc)
• openresty/lua-nginx-module@9fa316f
• openresty/lua-nginx-module@eed28fc (optimize: fixed the pre-allocated number of keys in the ngx.socket.tcp metatable)
• openresty/lua-nginx-module@6c25b7b (optimize: removed declaration of obsolete 'ngx_http_lua_inject_logby_ngx_api')
• openresty/lua-nginx-module@c618d0d (code cache lookup bugfix)
• openresty/lua-nginx-module@881bf91 (bugfix: prevent resp headers APIs to have \r \n)
• openresty/lua-nginx-module@246ec8a (refactor: simpler cache key gen)
• openresty/lua-nginx-module@f45908c (refactor: smaller cache keys)
• openresty/lua-nginx-module@0c755ed (bugfix: set_by_lua_file with NGINX vars)
• openresty/lua-nginx-module@39c2ead (optimize: code cache lookup)
• openresty/lua-nginx-module@09484e8 (bugfix: init_worker_by_lua mutating main confs)
• openresty/lua-nginx-module@d3dbc0c (TLS 1.3 session skip)
• openresty/lua-nginx-module@32dd6a3
• openresty/lua-nginx-module@59b6430
• openresty/lua-nginx-module@33a5517
• openresty/lua-nginx-module@a7afd56 (ngx.pipe with env vars)

ngx_http_lua v0.10.15

• openresty/lua-nginx-module@28cf5ce (str_replace_char FFI API for regex module)
• openresty/lua-nginx-module@f87d1f1 (ngx.pipe bugfix)
• openresty/lua-nginx-module@afeeb84 (ngx.pipe bugfix)
• openresty/lua-nginx-module@ee47e55 (ngx.pipe bugfix)
• openresty/lua-nginx-module@761ddca (cosocket conn queue bugfix)
• openresty/lua-nginx-module@8edb21a (cosocket conn queue bugfix)
• openresty/lua-nginx-module@b2af4d3
• openresty/lua-nginx-module@aef03eb (ngx.pipe support)
• openresty/lua-nginx-module@c2940c1 (cosocket conn queuing)
• openresty/lua-nginx-module@2fb8f12
• openresty/lua-nginx-module@248060b
• openresty/lua-nginx-module@fbb8919
• openresty/lua-nginx-module@cec2a09
• openresty/lua-nginx-module@08a9baa
• openresty/lua-nginx-module@84338ab
• openresty/lua-nginx-module@f64ec8c
• openresty/lua-nginx-module@e94f2e5 (segfault in init_worker_by* with NGINX >= 1.15.0)
• openresty/lua-nginx-module@55743ae
• openresty/lua-nginx-module@b5ffb11
• openresty/lua-nginx-module@52af63a
• openresty/lua-nginx-module@809192c
• openresty/lua-nginx-module@53519cd
• openresty/lua-nginx-module@23e69fb

ngx_stream_lua test cases to port

• openresty/lua-nginx-module@53519cd feat: sending nil/bool in cosockets
• openresty/lua-nginx-module@f64ec8c bugfix: tcpsock:setkeepalive nginx shutdown fix
• cosocket connection queuing
• openresty/lua-nginx-module@b2af4d3 bugfix: inlined Lua code snippets code cache fix
• openresty/lua-nginx-module@b5ffb11 feature: implemented the receiveany() upstream cosocket method
• openresty/lua-nginx-module@189ba24 feature: log location of function definition when timers fail to run
• openresty/lua-nginx-module@9a892b8 bugfix: coroutine.wrap propagate errors to the parent coroutine
• openresty/lua-nginx-module@2a19073 change: removed error logging on coroutine runtime errors

ngx_stream_lua features to port

• enable ngx.pipe API in stream
• enable ngx.process API in stream
• enable tcpsock:receiveany() API in stream
• port ngx.get_phase() to FFI in stream