Bundled extensions should declare slf4j and Jackson as "provided" about openrefine HOT 5 CLOSED

Took me a while to figure out how to make a schema that the Wikibase extension would let me save, but save/restore appears to work correctly.

from openrefine.

Wonderful find! Glad we finally figured this out.

from openrefine.

That would be a pretty natural solution indeed! I'm curious to see if Jackson serialization still works as it should after that.

from openrefine.

I'm curious to see if Jackson serialization still works as it should after that.

Do you have a particular test (manual or automated) that was failing before? Was the broken serialization on the wire or on disk?

FWIW all unit and end to end tests pass with this fix (and the Butterfly patch reverted).

from openrefine.

This is a problem that sadly isn't covered by the test suite because the class loaders used when running unit tests are configured differently to the normal operation of the application.
It might be possible to write a unit test for the problem by explicitly invoking the class loaders in the way they are in the normal application.

One way to test this manually would be to use the Wikibase integration (saving a Wikibase schema in a project should be enough, no need to upload), restarting OpenRefine and checking that the schema is indeed restored as expected. This would test Jackson serialization and deserialization under normal circumstances.

from openrefine.