Git Product home page Git Product logo

Comments (6)

pkumar2001 avatar pkumar2001 commented on June 12, 2024 1

Can I work on this?

from openrefine.

wetneb avatar wetneb commented on June 12, 2024 1

I think going above 80% would be pretty nice already, but I have no idea how much work that involves.
Of course the goal would be to make actual assertions about the parsed values and not just trigger code paths for the sake of coverage. Let us know how it goes :)

from openrefine.

wetneb avatar wetneb commented on June 12, 2024 1

@shivam999876 something along those lines yes, but it would need to include quite a few more cases to reach a decent coverage. I would recommend we let @pkumar2001 have a go at this first, as I have assigned them to the issue already. Feel free to tackle another issue where no-one is assigned yet.

from openrefine.

pkumar2001 avatar pkumar2001 commented on June 12, 2024

what is the target test coverage?

from openrefine.

shivam999876 avatar shivam999876 commented on June 12, 2024

@wetneb Will the code work?
//Code to fix the issue.
import static org.junit.Assert.*;
import org.junit.Test;
import java.util.Calendar;

public class CalendarParserTest {

@Test
public void testParseValidDate() {
    CalendarParser parser = new CalendarParser();
    Calendar result = parser.parse("2024-03-20");
    assertNotNull(result);
    assertEquals(2024, result.get(Calendar.YEAR));
    assertEquals(Calendar.MARCH, result.get(Calendar.MONTH));
    assertEquals(20, result.get(Calendar.DAY_OF_MONTH));
}

@Test
public void testParseInvalidDate() {
    CalendarParser parser = new CalendarParser();
    Calendar result = parser.parse("invalid-date");
    assertNull(result);
}

@Test
public void testParseNullInput() {
    CalendarParser parser = new CalendarParser();
    Calendar result = parser.parse(null);
    assertNull(result);
}

}

from openrefine.

shivam999876 avatar shivam999876 commented on June 12, 2024

@wetneb Thanks for your response.

from openrefine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.