Git Product home page Git Product logo

Comments (9)

schnuerle avatar schnuerle commented on June 11, 2024 2

We did have a big discussion on #838 about some response codes. @marie-x It seems we should be using 401 and we can remove 403 from the spec. Do you see any issue with that?

from mobility-data-specification.

marie-x avatar marie-x commented on June 11, 2024 1

We did have a big discussion on #838 about some response codes. @marie-x It seems we should be using 401 and we can remove 403 from the spec. Do you see any issue with that?

Sounds great!

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024 1

So remove 403 for sure.

What about 200 vs 201? Seems like 201 is valuable to have to ensure the item was created, vs the more generic 200 when all is ok. So both are good to keep?

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

@marie-x @schnuerle How about the difference between 200 and 201?

201 is mentioned here as what a successful POST should return, different from 200 in the Agency docs.

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

So remove 403 for sure.

Done.

Seems like 201 is valuable to have to ensure the item was created, vs the more generic 200 when all is ok. So both are good to keep?

Yep, I'll keep both in the OpenAPI docs.

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

So should any 403s like in Vehicles in Agency, and in Jurisdiction, be changed to 401s? Or should 403s be removed completely?

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

Jurisdiction shouldn't have either, because it is public / shouldn't throw "Not authorized" errors.

In Agency (and Metrics, Provider) we should use 401 everywhere there could be an authorization error, and remove 403 entirely.

I think only the Agency docs in the spec need the update though.

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

This is done in the OpenAPI docs.

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

Everything mentioned here should be resolved as part of #856 so focusing on that Issue now.

from mobility-data-specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.