Git Product home page Git Product logo

Comments (7)

schnuerle avatar schnuerle commented on June 11, 2024 1

I think 5 was just formatting, fixed here.

6 I think leaving as milliseconds makes sense based on the field name and intention, because it's not the timestamp of when this happened, it's the calculated difference in timestamps.

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

For 1, 2, 5, and 7 you could do a PR.

For 3, the 'may have' refers to the fact that you may have some combination of the following fields.

For 4, in passenger services it's a string because I can be a variety of sources.

For 6, MDS defaults to milliseconds as our common unit. I don't think we use seconds elsewhere.

For 8, instead of currency it should probably be an integer and in cents.

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

I don't see what the issue is with 5?

For 6 I think those should just be renamed timestamp since that's what we use everywhere; and yes, it is milliseconds since Unix epoch.

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

For 2 the name is now consistent here.

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

7 is fixed here with underscore - Kegan does that change it form OpenAPI?

And 1 is fixed here, which also may need an OpenAPI update.

from mobility-data-specification.

thekaveman avatar thekaveman commented on June 11, 2024

These items were all addressed in OpenAPI in openmobilityfoundation/mds-openapi#36

from mobility-data-specification.

schnuerle avatar schnuerle commented on June 11, 2024

Closing this multi-item issue. If you have ideas from this list that weren't addressed, please open a new issue to discuss them. Thanks!

from mobility-data-specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.