openfaas / go-sdk Goto Github PK

Examples should be added for all the supported functionalities by go-sdk, so users can use it to build capabilities at their end.

https://docs.openfaas.com/reference/rest-api/#logs

add openfaas=1 annotation to create and update namespace operation

Change from returning error to HttpError to allow the end-user to read the Status code from the server, along with the error message we already return.

type HttpError struct {
	Err    error
	Status int
}

func (e *HttpError) Error() string {
	return e.Err.Error()
}

Adding a context allows for better cancellation and propagation of cancellations.

func (s *Client) DeleteFunction(functionName, namespace string) error {
	req, err := http.NewRequest(http.MethodPost, u.String(), bodyReader)

=>

func (s *Client) DeleteFunction(ctx context.Context, functionName, namespace string) error {
	req, err := http.NewRequestWithContext(ctx, http.MethodPost, u.String(), bodyReader)

setting FAAS_DEBUG=1 environment variable let's users debug faas-cli operations. We want to support the same in go-sdk. This will help users to debug issues in their codebase.

Openfaas implementations support namespace management. Add the support for same in go-sdk.

https://www.openfaas.com/blog/kubernetes-tokens-openfaas-api/

Add example for deploying a function to the README

Use the env function from the store?

Look at the code block. Instead of using provide http client in parameter, default one is being set

https://docs.openfaas.com/reference/rest-api/#secrets