openapi-tools / jackson-dataformat-hal-provider Goto Github PK

Continuing from our discussion in openapi-tools/jackson-dataformat-hal#32, I looked at the initial implementation of the JAX-RS provider. I was wondering why you didn't just use the one I initially provided in the pull request.

The reason I didn't use the HALMapper there, is that it means you always create a new ObjectMapper. But the provider already creates the ObjectMapper so you're overriding that one with the HALMapper. This means that any custom configuration that might've been applied is lost.

I also provided alternative implementations for all constructors since you otherwise end up with a regular ObjectMapper even when you use this HAL-specific provider. I'm not sure when each of these constructors is used though. But it seems good to avoid such flaky behavior.

As for the _locateMapperViaProvider method, I had to override this to ensure that this HAL-specific provider doesn't change an existing ObjectMapper instance. This allows a normal ObjectMapper to exist side-by-side with this HAL-specific ObjectMapper.

Honestly though, I'm not exactly sure how JacksonJsonProvider works. I just tried to ensure that I never override the ObjectMapper that it uses.

Just starting to look at this. But I noticed that the name of the project doesn't correspond to the convention used by Jackson. I think it should be jackson-jaxrs-hal-provider. I think this will also make it easier to find this dependency and understand what it does. I hope it's still okay to rename it since it would affect the repo URL and artifact name as well. But that's why it seems better to do this as early as possible.