openalto / alto-domain-agent Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 118 KB

An ALTO agent implementation for cross-domain networks.

License: MIT License

Java 90.66% Python 9.34%

alto-domain-agent's People

Contributors

Watchers

Forkers

yjlcoder

alto-domain-agent's Issues

alto-nova cannot work well with java external call

Error log as following:

[Thread-21] ERROR org.snlab.unicorn.handlers.OrchestratorQueryHandler - Traceback (most recent call last):  File "/usr/bin/nova", line 4, in <module>    __import__('pkg_resources').run_script('alto-nova==0.1', 'nova')  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 748, in run_script    self.require(requires)[0].run_script(script_name, ns)  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 1517, in run_script    exec(code, namespace, namespace)  File "/usr/lib/python3.4/site-packages/alto_nova-0.1-py3.4.egg/EGG-INFO/scripts/nova", line 12, in <module>    response_body = json.loads(sys.argv[1])  File "/usr/lib64/python3.4/json/__init__.py", line 318, in loads    return _default_decoder.decode(s)  File "/usr/lib64/python3.4/json/decoder.py", line 343, in decode    obj, end = self.raw_decode(s, idx=_w(s, 0).end())  File "/usr/lib64/python3.4/json/decoder.py", line 361, in raw_decode    raise ValueError(errmsg("Expecting value", s, err.value)) from NoneValueError: Expecting value: line 1 column 1 (char 0)

Maybe the python version issue.

Wrong accepted action

With request {'action': 'new', 'query-type': 'path-query', 'query-desc': [], 'query-id': 1}, the agent throw an exception. Here is the dump.

[qtp1692036285-22] ERROR org.snlab.unicorn.handlers.OrchestratorQueryHandler - Invalid query body:
com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'action': was expecting ('true', 'false' or 'null')
 at [Source: action=new&query-type=resource-query&query-id=2; line: 1, column: 7]
        at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1702)
        at com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:558)
        at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._reportInvalidToken(ReaderBasedJsonParser.java:2839)
        at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._handleOddValue(ReaderBasedJsonParser.java:1903)
        at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextToken(ReaderBasedJsonParser.java:749)
        at com.fasterxml.jackson.databind.ObjectMapper._initForReading(ObjectMapper.java:3850)
        at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:3799)
        at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2858)
        at org.snlab.unicorn.handlers.OrchestratorQueryHandler.parseBody(OrchestratorQueryHandler.java:68)
        at org.snlab.unicorn.handlers.OrchestratorQueryHandler.handle(OrchestratorQueryHandler.java:76)
        at org.snlab.unicorn.UnicornService$ControlServiceResource.getControlStreamQuery(UnicornService.java:117)

Cherry-Pick patches in demo-special branch to master

It's time to merge patches into the master branch.

Move path vector configuration from controller to agent side

Move the business logic of computeResource to the agent side. Just read bandwidth information from the controller (alto-bwmonitor).

Query handler should have threads running while true loop

Also, the query handler should provide close() method to stop the running thread. It avoids the unlimited loop.

HTTP Fluent Client: Response content has been already consumed

Exception in thread "Thread-21" java.lang.IllegalStateException: Response content has been already consumed
	at org.apache.http.client.fluent.Response.assertNotConsumed(Response.java:56)
	at org.apache.http.client.fluent.Response.handleResponse(Response.java:88)
	at org.apache.http.client.fluent.Response.returnContent(Response.java:97)
	at org.snlab.unicorn.adapter.ODLAdapter.getResource(ODLAdapter.java:225)
	at org.snlab.unicorn.handlers.OrchestratorQueryHandler.doResourceQuery(OrchestratorQueryHandler.java:154)
	at org.snlab.unicorn.handlers.OrchestratorQueryHandler.doQuery(OrchestratorQueryHandler.java:137)
	at org.snlab.unicorn.handlers.OrchestratorQueryHandler.lambda$loopForQueryUpdate$0(OrchestratorQueryHandler.java:197)
	at java.lang.Thread.run(Thread.java:748)

Write a mock adapter to use by default

A mock adapter is necessary for testing or exception handling.

No RSA in the current resource query? I think

I think the current resource query do not provide RSA. So it is the full path vector information in the resource query response.

Require an external process to handle stateless RSA request. No need a http server, I prefer an external subprocess wrapper.

Incorrect query desc converting for ODL

The srcIp and dstIp fields in ODL request is IpPrefix. So pass the query desc string directly should not be correct.

Decouple odl model from generic ControllerAdapter interface

ControllerAdapter.class should be a generic interface and never couple with any platform-specific models.

Move requirePathQuery() and requireResourceQuery() from adapter to handler

The ControllerAdapter does not maintain the query-id information. So it cannot handle the requirePathQuery() and requireResourceQuery() signal for a special query-id. We need to move these methods to OrchestratorQueryHandler.

No data change notification from websocket

Although ODLAdapter started a websocket to listen the data change, yet no notification retrieved.

Change data structure of query items from Set to List

Referring to this link, now the data structure of query items is Set, but we need to change it to List, because of the importance of according sequences of requests and responses.

Migrate javax.json to jackson if possible

Some classes are using javax.json to serialize/deserialize JSON strings and objects. It is time to migrate the parser to com.fastxml.jackson. It will clean up the code and improve the maintainability.

Execute bootstrap after jersey application initialized

Currently, there is some bootstrap code (for orchestrator registration) in the construction function of jersey application. This code may be loaded before the jersey application finishes its initialization. We need to make it executed after the application initialized.

This Q & A in stackoverflow may help us: https://stackoverflow.com/questions/7449165/jersey-initialization-code-after-webapp-is-fully-started.

Register the management IP with a given host ip.

Required by this issue.

openalto / alto-domain-agent Goto Github PK

alto-domain-agent's People

Contributors

Watchers

Forkers

alto-domain-agent's Issues

Recommend Projects

Recommend Topics

Recommend Org