Support OpenTelemetry protocol and agent exporter about opentelemetry-dotnet HOT 15 CLOSED

Ugh. submodules sounds nice in principle and a bit nasty in practice. I'll make a copy of the files.

from opentelemetry-dotnet.

Also should update src\OpenTelemetry.Exporter.Ocagent\Implementation\SpanDataExtentions.cs#39 with producer and consumer span types in the new protos

from opentelemetry-dotnet.

fyi the protos are in https://github.com/open-telemetry/opentelemetry-proto now

from opentelemetry-dotnet.

One thing I've wondered, would it make sense to publish the generated proto code out of that repo rather than importing it to this one as a submodule or so forth?

from opentelemetry-dotnet.

I have very little experience with submodules. Every time I tried it was not a streamline thing. It always took more time to fix tooling than simple copying of rarely updated files take. And shipping a hotfix that only addresses a single issue and only need one of many changes is impossible.

If you have good examples where this approach worked just fine - I'm happy to try again and learn.

from opentelemetry-dotnet.

I've found submodules to be unwieldy as well - we can just copy files around for now I reckon.

from opentelemetry-dotnet.

Have feelings changed about how to proceed with these .proto files? At the very least a reference to a commit from the proto repo is necessary. We could copy the .proto files over and generate as part of the build of this project I think. No need to check-in the intermediate g.cs files.

from opentelemetry-dotnet.

Java went submodule way: https://github.com/open-telemetry/opentelemetry-java/tree/master/proto/src/main We can try the same

from opentelemetry-dotnet.

I don't have strong feelings

from opentelemetry-dotnet.

As discussed on Gitter, @pjanotti assigning this to you

from opentelemetry-dotnet.

This should be complete now. @pjanotti Can you confirm and close this?

from opentelemetry-dotnet.

We are still missing the instrumentation library in the exports...

from opentelemetry-dotnet.

@eddynaka please check if the instrumentationlibrary info is missing in the otlp exporter.

from opentelemetry-dotnet.

We are still missing the instrumentation library in the exports...

This is because ActivitySource is blank for those DiagnosticSourceInstrumentation activities. One proposed fix would be to modify the legacy activity with correct ActivitySource.

from opentelemetry-dotnet.

This work is complete. The lack of InstrumentationLibrary info is a bug in the instrumentations, not an exporter. Closing this.

from opentelemetry-dotnet.