Add ActivitySource to SamplingParameters about opentelemetry-dotnet HOT 4 CLOSED

SamplingParameters follows the specification which does not contain ActivitySource/Scope information. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#:~:text=to%20be%20created.-,Required%20arguments%3A,-Context%20with%20parent

Related: #4371

from opentelemetry-dotnet.

open-telemetry/opentelemetry-specification#1942 More history. I was added, but then reverted.

from opentelemetry-dotnet.

There's a fine line implementing what the spec says, and what the SDK says is needed. I'm sure there are places in our SDK that we go beyond what the spec says as a minimum.

I don't see anywhere in the spec that say we "can't" or "Shouldn't" do it though.

That is to say, it's a choice that we're not going to pass it in within the .NET implementation. If we're not going to do this, I think we should close of this issue and give some closure for @FstTesla so they're not waiting on it.

from opentelemetry-dotnet.

I don't see anywhere in the spec that say we "can't" or "Shouldn't" do it though.

Yes. Remember that scopes were added to samplinginput to the spec, but then reverted, and there are plenty of open spec issues, like open-telemetry/opentelemetry-specification#3867
We need to wait for spec resolution before making a new addition.

@FstTesla We are not adding it to OTel .NET, unless the spec is changed to allow that. It is possible that spec might be solving this problem in a different way. Please follow the spec issue for updates.

from opentelemetry-dotnet.