Git Product home page Git Product logo

Comments (11)

thomwiggers avatar thomwiggers commented on July 4, 2024 1

This is kind of a problem with how liboqs ends up getting packaged, with all compiler errors turned on. I've opened open-quantum-safe/liboqs#1432 to discuss this upstream.

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 4, 2024 1

/Users/christopherpatton/cf-repos/CRYPTO/rustls_pq/target/debug/build/oqs-sys-ec6822a9eb5cd43c/out/build/include/oqs/common.h:14:10: fatal error: 'stdlib.h' file not found

stdlib.h not found sounds a bit more significant...

from liboqs-rust.

bwesterb avatar bwesterb commented on July 4, 2024

Fixed in main.

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 4, 2024

In the mean time, I need to consider if I want to set -Wno-error in build.rs...

from liboqs-rust.

cjpatton avatar cjpatton commented on July 4, 2024

I've encountered a similar problem even after checking out main (508a13c0) I'm using rust 1.69 on macOS (Apple Silicon).

oqs-sys = { git = "https://github.com/open-quantum-safe/liboqs-rust.git", branch = "main" }
oqs = { git = "https://github.com/open-quantum-safe/liboqs-rust.git", branch = "main", default-features = false, features = ["kyber", "std"] }
... snipped ...

  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_192s_simple_clean.dir/pqclean_sphincs-shake256-192s-simple_clean/utils.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256f_robust_clean.dir/pqclean_sphincs-shake256-256f-robust_clean/wots.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256f_simple_clean.dir/pqclean_sphincs-shake256-256f-simple_clean/utils.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256s_robust_clean.dir/pqclean_sphincs-shake256-256s-robust_clean/sign.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256f_simple_clean.dir/pqclean_sphincs-shake256-256f-simple_clean/wots.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256s_robust_clean.dir/pqclean_sphincs-shake256-256s-robust_clean/thash_shake256_robust.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_192s_simple_clean.dir/pqclean_sphincs-shake256-192s-simple_clean/wots.c.o
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256s_robust_clean.dir/pqclean_sphincs-shake256-256s-robust_clean/utils.c.o
  [100%] Built target sphincs_shake256_192s_robust_clean
  [100%] Building C object src/sig/sphincs/CMakeFiles/sphincs_shake256_256s_robust_clean.dir/pqclean_sphincs-shake256-256s-robust_clean/wots.c.o
  [100%] Built target sphincs_shake256_256f_robust_clean
  [100%] Built target sphincs_shake256_256f_simple_clean
  [100%] Built target sphincs_shake256_192s_simple_clean
  [100%] Built target sphincs_shake256_256s_robust_clean
  [100%] Building C object src/CMakeFiles/oqs.dir/kem/kem.c.o
  [100%] Building C object src/CMakeFiles/oqs.dir/sig/sig.c.o
  [100%] Linking C static library ../lib/liboqs.a
  [100%] Built target oqs
  cargo:root=/Users/christopherpatton/cf-repos/CRYPTO/rustls_pq/target/debug/build/oqs-sys-ec6822a9eb5cd43c/out
  cargo:rustc-link-lib=static=oqs
  cargo:rustc-link-search=native=/Users/christopherpatton/cf-repos/CRYPTO/rustls_pq/target/debug/build/oqs-sys-ec6822a9eb5cd43c/out/build/lib

  --- stderr
  CMake Warning:
    Manually-specified variables were not used by the project:

      CMAKE_CXX_COMPILER
      CMAKE_CXX_FLAGS


  /Users/christopherpatton/cf-repos/CRYPTO/rustls_pq/target/debug/build/oqs-sys-ec6822a9eb5cd43c/out/build/include/oqs/common.h:14:10: fatal error: 'stdlib.h' file not found
  thread 'main' panicked at 'Unable to generate bindings: ClangDiagnostic("/Users/christopherpatton/cf-repos/CRYPTO/rustls_pq/target/debug/build/oqs-sys-ec6822a9eb5cd43c/out/build/include/oqs/common.h:14:10: fatal error: 'stdlib.h' file not found\n")', /Users/christopherpatton/.cargo/git/checkouts/liboqs-rust-4f844d0c84f6a965/508a13c/oqs-sys/build.rs:33:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 4, 2024

I'm afraid I will not have time to do anything for the next couple of days at least...

from liboqs-rust.

cjpatton avatar cjpatton commented on July 4, 2024

No worries!

from liboqs-rust.

cjpatton avatar cjpatton commented on July 4, 2024

I managed to resolve my specific issue by using homebrew's clang instead of Apple's (brew install llvm). It would be great to cut a release: I can get main to compile but not 0.7.2.

from liboqs-rust.

Lekensteyn avatar Lekensteyn commented on July 4, 2024

I managed to resolve my specific issue by using homebrew's clang instead of Apple's (brew install llvm). It would be great to cut a release: I can get main to compile but not 0.7.2.

That's odd. Like Thom said, something seems really wrong if stdlib.h cannot be found. Is it possible that you have not installed XCode Command Line Tools after upgrading your system? Normally xcode-select --install should work.

from liboqs-rust.

cjpatton avatar cjpatton commented on July 4, 2024

I tried deleting the xcode stuff and reinstalling, no dice. There is likely something going on with my environment that has nothing to do with liboqs :) In fact, the other day I ended up building clang version 12.0.0 from source and installing it, it's possible that has messed things up a bit. I am hopeless with macOS.

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 4, 2024

Should be fixed by release 0.8.0

from liboqs-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.