Git Product home page Git Product logo

Comments (7)

thomwiggers avatar thomwiggers commented on July 24, 2024

This should be possible by letting oqs-sys' build.rs find liboqs and its header files. We should probably do a vendor style feature like the openssl-sys crate.

However, I do not have time to make the required changes to do this right now. I would review and potentially merge a PR, but it would also need to expand CI to cover these new build scenarios.

from liboqs-rust.

clausecker avatar clausecker commented on July 24, 2024

Thank you. Unfortunately I do not have any Rust experience, so I'll not be able to assist you with this.

from liboqs-rust.

tranzystorekk avatar tranzystorekk commented on July 24, 2024

I took a quick glance at this out of curiosity, but liboqs doesn't seem to provide a pkg-config file, and cmake scripts alone aren't easily read from build.rs :/

from liboqs-rust.

wucke13 avatar wucke13 commented on July 24, 2024

Now that @tranzystorek-io provided open-quantum-safe/liboqs#1435 which was merged (thank you!!!), I think the discussion should continue here. @thomwiggers are there any specific requirements for such a PR? So far I only got

  • has to be checked by CI

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 24, 2024

This should be fixed by #190 right?

from liboqs-rust.

clausecker avatar clausecker commented on July 24, 2024

@thomwiggers This here is issue #190, so I'm not sure what you meant to link.

from liboqs-rust.

thomwiggers avatar thomwiggers commented on July 24, 2024

My bad, #211

from liboqs-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.